New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove authorized application entity and related controller and tests #34146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jolelievre
commented
Oct 3, 2023
•
edited
edited
Questions | Answers |
---|---|
Branch? | develop |
Description? | Remove authorized application entity and related controller and tests |
Type? | refacto |
Category? | BO |
BC breaks? | no |
Deprecations? | no |
How to test? | CI green and UI tests green |
UI Tests | https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/6393313823 |
Fixed issue or discussion? | Fixes #33721 |
Related PRs | ~ |
Sponsor company | ~ |
… also remove the Doctrine entity and its repository
jolelievre
changed the title
Remove authorize application entity and related controller and tests
Remove authorized application entity and related controller and tests
Oct 3, 2023
tleon
previously approved these changes
Oct 3, 2023
jolelievre
force-pushed
the
clean-applications
branch
from
October 3, 2023 13:24
e1dbbb8
to
48e87a7
Compare
nicosomb
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-3559
+59
❤️
nesrineabdmouleh
approved these changes
Oct 3, 2023
@jolelievre Don't forget the milestone 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.