Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AddressController.php #34167

Closed
wants to merge 1 commit into from
Closed

Fix AddressController.php #34167

wants to merge 1 commit into from

Conversation

metacreo
Copy link

@metacreo metacreo commented Oct 4, 2023

Duplicate call function. Address form filled second time. Fix bugs: #34080 and #33991

Questions Answers
Branch? 8.1.x / develop
Description? Duplicate function call. Address form filled two times. Fix bugs: #34080 and #33991
Type? bug fix
Category? FO
BC breaks? no
Deprecations? yes
How to test? Indicate how to verify that this change works as expected.
UI Tests Please run UI tests and paste here the link to the run. Read this page to know why and how to use this tool..
Fixed issue or discussion? Fixes #34080, Fixes #33991
Related PRs If theme, autoupgrade or other module change is needed to make this change work, provide a link to related PRs here.
Sponsor company Your company or customer's name goes here (if applicable).

Duplicate call function. Address form filled two times.
@metacreo metacreo requested a review from a team as a code owner October 4, 2023 13:47
@prestonBot
Copy link
Collaborator

Hello @metacreo!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot prestonBot added the Bug fix Type: Bug fix label Oct 4, 2023
Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are UI tests, just to make sure this PR doesn't break anything:

https://github.com/matthieu-rolland/ga.tests.ui.pr/actions/runs/6407757506

@matthieu-rolland
Copy link
Contributor

matthieu-rolland commented Oct 4, 2023

why do we have 2 pull requests for this ? :D #34152

for your information you could have changed the base in the PR directly, via the selector at the top of the PR ;)

And no need to have it both on 8.1.x and develop... every week bug fixes are brought to develop, so your fix will be integrated.

So you can delete the other PR... or delete this PR and change the base on the other PR... your choice 👍

@PrestaShop PrestaShop deleted a comment from prestonBot Oct 4, 2023
@metacreo
Copy link
Author

metacreo commented Oct 4, 2023

Please wait. Not all checks with good result. Please wait. After 8.1.1 -> 8.1.2 This fix not works.

@metacreo metacreo closed this Oct 4, 2023
@metacreo metacreo deleted the patch-2 branch October 4, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug fix Type: Bug fix
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants