Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete endpoints that have been moved to the module #35172

Merged
merged 3 commits into from Feb 12, 2024
Merged

Delete endpoints that have been moved to the module #35172

merged 3 commits into from Feb 12, 2024

Conversation

tleon
Copy link
Contributor

@tleon tleon commented Jan 25, 2024 •
edited

Questions Answers
Branch? develop
Description? Delete endpoints that have been moved to the module in PR PrestaShop/ps_apiresources#9
Type? refacto
Category? BO
BC breaks? no
Deprecations? no
How to test? CI & ui tests 馃煝
UI Tests https://github.com/tleon/ga.tests.ui.pr/actions/runs/7872955690
Fixed issue or discussion? Fixes #35127
Related PRs PrestaShop/ps_apiresources#9 (merged)
Sponsor company PrestaShop SA

@tleon tleon self-assigned this Jan 25, 2024
@prestonBot prestonBot added the Refactoring Type: Refactoring label Jan 25, 2024
@tleon tleon force-pushed the Issue-35127-clean-core-from-endpoints branch 2 times, most recently from e3ea3e3 to 922c22f Compare January 25, 2024 16:04
@tleon tleon force-pushed the Issue-35127-clean-core-from-endpoints branch 9 times, most recently from de3f46a to b81c9d4 Compare January 29, 2024 15:03
@tleon tleon marked this pull request as ready for review January 29, 2024 15:27
@tleon tleon requested a review from a team as a code owner January 29, 2024 15:27
matks
matks previously approved these changes Jan 30, 2024
View reviewed changes
@prestonBot prestonBot added the develop Branch label Jan 30, 2024
jolelievre
jolelievre previously approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tleon

tests/Integration/ApiPlatform/DomainSerializerTest.php Outdated Show resolved Hide resolved
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Jan 31, 2024
@paulnoelcholot
Copy link

Hello @tleon

Several auto tests are failing, can you check that?

Thanks!

@paulnoelcholot paulnoelcholot added Waiting for dev Status: action required, waiting for tech feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Feb 6, 2024
@tleon tleon dismissed stale reviews from jolelievre and matks via 473cdf0 February 7, 2024 17:33
@tleon tleon force-pushed the Issue-35127-clean-core-from-endpoints branch from b81c9d4 to 473cdf0 Compare February 7, 2024 17:33
@tleon tleon force-pushed the Issue-35127-clean-core-from-endpoints branch 2 times, most recently from 9cb3213 to 6c1572e Compare February 8, 2024 09:36
@tleon tleon force-pushed the Issue-35127-clean-core-from-endpoints branch 2 times, most recently from af7509f to 461bc85 Compare February 8, 2024 09:40
jolelievre
jolelievre previously approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tleon

@tleon tleon requested a review from a team as a code owner February 8, 2024 10:55
@Progi1984 Progi1984 force-pushed the Issue-35127-clean-core-from-endpoints branch 2 times, most recently from bf42a7b to 6ab9364 Compare February 8, 2024 11:44
@tleon tleon force-pushed the Issue-35127-clean-core-from-endpoints branch from 6ab9364 to 2753366 Compare February 9, 2024 08:45
@Progi1984 Progi1984 force-pushed the Issue-35127-clean-core-from-endpoints branch from 2753366 to 6ab9364 Compare February 9, 2024 10:00
@tleon tleon force-pushed the Issue-35127-clean-core-from-endpoints branch from 6ab9364 to ad05e7a Compare February 9, 2024 10:01
@tleon tleon removed the Waiting for dev Status: action required, waiting for tech feedback label Feb 9, 2024
jolelievre
jolelievre reviewed Feb 9, 2024
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only needs rebase, and update of the lock since PrestaShop/ps_apiresources#10 has just been merged

Then it's all good for me

@tleon tleon force-pushed the Issue-35127-clean-core-from-endpoints branch from ad05e7a to 243829e Compare February 12, 2024 14:06
jolelievre
jolelievre approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tleon

@M0rgan01 M0rgan01 added this to the 9.0.0 milestone Feb 12, 2024
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Feb 12, 2024
@jolelievre jolelievre removed the Waiting for QA Status: action required, waiting for test feedback label Feb 12, 2024
Progi1984
Progi1984 approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for UI Tests

@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Feb 12, 2024
@tleon tleon merged commit 7d99a22 into PrestaShop:develop Feb 12, 2024
26 checks passed
@jolelievre jolelievre removed the Waiting for QA Status: action required, waiting for test feedback label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@jolelievre jolelievre jolelievre approved these changes

@M0rgan01 M0rgan01 M0rgan01 approved these changes

@matks matks Awaiting requested review from matks

@boherm boherm Awaiting requested review from boherm

@nicosomb nicosomb Awaiting requested review from nicosomb

Assignees

@tleon tleon

Labels
develop Branch Refactoring Type: Refactoring
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

Add missing tests CI on module apiressources
10 participants
@tleon @paulnoelcholot @nicosomb @Progi1984 @matks @jolelievre @boherm @M0rgan01 @ps-jarvis @prestonBot