Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add params to actionValidateOrderBefore #35350

Merged
merged 1 commit into from Feb 20, 2024
Merged

Add params to actionValidateOrderBefore #35350

merged 1 commit into from Feb 20, 2024

Conversation

PrestaEdit
Copy link
Contributor

Questions Answers
Branch? develop
Description? Add some params to hook call and allow to change OrderState ID if needed
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Sponsor company @wepika

@PrestaEdit PrestaEdit requested a review from a team as a code owner February 14, 2024 10:33
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Feb 14, 2024
@kpodemski kpodemski added Needs documentation Needs an update of the developer documentation Waiting for QA Status: action required, waiting for test feedback labels Feb 20, 2024
@paulnoelcholot
Copy link

Hello

Can we have a How to test please :)

https://github.com/paulnoelcholot/testing_pr/actions/runs/7899132661/workflow CI = 🟢

@paulnoelcholot paulnoelcholot added the Waiting for PM Status: action required, waiting for product feedback label Feb 20, 2024
@paulnoelcholot
Copy link

@PrestaShop/product-council

@kpodemski
Copy link
Contributor

@paulnoelcholot as far as I remember QA has a module to test hooks, you could dump these extra params there

@paulnoelcholot paulnoelcholot removed the Waiting for PM Status: action required, waiting for product feedback label Feb 20, 2024
@paulnoelcholot
Copy link

Hello @PrestaEdit,

I tested your PR and it's good for me! 🎉

Thanks!

image

@paulnoelcholot paulnoelcholot added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Feb 20, 2024
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@matks
Copy link
Contributor

matks commented Feb 20, 2024

Thank you @PrestaEdit

@matks matks merged commit 20ef5db into PrestaShop:develop Feb 20, 2024
23 checks passed
@matks matks added this to the 9.0.0 milestone Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodemski kpodemski kpodemski approved these changes

@mflasquin mflasquin mflasquin approved these changes

@paulnoelcholot paulnoelcholot paulnoelcholot approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement Needs documentation Needs an update of the developer documentation QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@PrestaEdit @paulnoelcholot @kpodemski @prestonBot @matks @mflasquin