Improve TokenAuthenticator #35368
Merged
Improve TokenAuthenticator #35368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
M0rgan01
commented
Feb 15, 2024
•
M0rgan01
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | Improve TokenAuthenticator. The logic in the support function was in the wrong place |
| Type? | bug fix |
| Category? | BO |
| BC breaks? | no |
| Deprecations? | no |
| How to test? | See #35306 |
| UI Tests | https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/8013060503 |
| Fixed issue or discussion? | Fixes #35306 |
| Related PRs | PrestaShop/ps_apiresources#14 |
| Sponsor company | - |
M0rgan01
force-pushed
the
fix/35306
branch
3 times, most recently
from
d21b32e
to
e3ca88b
Compare
M0rgan01
force-pushed
the
fix/35306
branch
2 times, most recently
from
5a97714
to
f31c40f
Compare
FabienPapet
previously approved these changes
Feb 20, 2024
jolelievre
force-pushed
the
fix/35306
branch
from
f31c40f
to
d9864dc
Compare
ps-jarvis
added
the
Waiting for QA
jolelievre
removed
the
Waiting for QA
jolelievre
dismissed stale reviews from FabienPapet and themself
via
9fab691
jolelievre
force-pushed
the
fix/35306
branch
from
d9864dc
to
9fab691
Compare
jolelievre
previously approved these changes
Feb 21, 2024
jolelievre
force-pushed
the
fix/35306
branch
from
8e8697a
to
8675b19
Compare
jolelievre
previously approved these changes
Feb 21, 2024
tleon
previously approved these changes
Feb 21, 2024
ps-jarvis
added
the
Waiting for QA
jolelievre
removed
the
Waiting for QA
jolelievre
force-pushed
the
fix/35306
branch
from
8675b19
to
6dabfb2
Compare
jolelievre
previously approved these changes
Feb 21, 2024
jolelievre
force-pushed
the
fix/35306
branch
3 times, most recently
from
fef5426
to
8b6937a
Compare
… its Passport fully based on the returne user interce, thus the reall scopes used are the ones from the JWT token now
jolelievre
force-pushed
the
fix/35306
branch
from
8b6937a
to
0ce50a4
Compare
jolelievre
force-pushed
the
fix/35306
branch
5 times, most recently
from
2511ebd
to
b5c23f9
Compare
…e security listener from the framework is triggered after all the provider code is executed
jolelievre
force-pushed
the
fix/35306
branch
from
b5c23f9
to
053868b
Compare
jolelievre
force-pushed
the
fix/35306
branch
from
053868b
to
ffa5b64
Compare
jolelievre
previously approved these changes
Feb 22, 2024
jolelievre
approved these changes
Feb 23, 2024
tleon
approved these changes
Feb 23, 2024
ps-jarvis
added
the
Waiting for QA
jolelievre
removed
the
Waiting for QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.