Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance is better when fetching all rows at once #4539

Closed
wants to merge 38 commits into from
Closed

Performance is better when fetching all rows at once #4539

wants to merge 38 commits into from

Conversation

studiokiwik
Copy link
Contributor

Moved from #4368

gRoussac and others added 30 commits October 6, 2015 14:12
@gRoussac
[-] IN: Wrong id_guest in cart.xml
c505c15
@gRoussac
[-] CORE : Fix #PSCSX-7012, bad length for compagny field (address) f…
8901373 
…or upgrade from < 1.5.2.0
@gRoussac
[*] BO : Add versioning to addJS to renew admin.js
14b2ca7
@gRoussac
[-] BO : Fix #PSCSX-7050, wrong pictures shown in AdminProducts
1e19325
@gRoussac
[-] BO : Notice in AdminCustomers
8f12447
@julienbourdeau
Merge pull request PrestaShop#4268 from gRoussac/notice
81aea52 
[-] BO : Notice in AdminCustomers
[*] TR: update Swedish installer
e4cb55f
@tchauviere
[-] FO : Added missing hook for AdvancedEU on accessories
b591e32
@gRoussac
Merge pull request PrestaShop#4270 from tchauviere/fix/missing-aeuc-h…
a0f2a12 
…ooks

[-] FO : Added missing hook for AdvancedEU on accessories
@gRoussac
Merge pull request PrestaShop#4275 from AlexEven/swedish
f1c5716 
[*] TR: update Swedish installer
@Mehdib92
[-] CORE : cleanCompareProducts interval
377a9d6 
The $period var was not taken into account in the SQL.
@gRoussac
Merge pull request PrestaShop#4279 from Mehdib92/patch-2
b89e4a3 
[-] CORE : cleanCompareProducts interval
Merge pull request PrestaShop#4241 from gRoussac/PSCSX-7012
2850be3 
[-] CORE : Fix #PSCSX-7012, bad length for compagny field (address) for upgrade from < 1.5.2.0
Merge pull request PrestaShop#4183 from gRoussac/guest
a645a2c 
[-] IN: Wrong id_guest in cart.xml
@gRoussac
[-] FO : Fix undefined var when no combinations
78d6fe6
@tchauviere
Merge pull request PrestaShop#4277 from gRoussac/js-und
afbbce2 
[-] FO : Fix undefined var when no combinations
[*] FO: theme.sql new demo address
c641bf6
@gRoussac
Merge pull request PrestaShop#4281 from AlexEven/1.6.1.x-sql
0d55695 
[*] FO: theme.sql new demo address
@tchauviere
Merge pull request PrestaShop#4267 from gRoussac/PSCSX-7050
dcb70b6 
[-] BO : Fix #PSCSX-7050, wrong pictures shown in AdminProducts
@jocel1
[-] FO : Fix performances issue with SpecificPrice (PSCSX-6942)
c140d7a
Merge pull request PrestaShop#4150 from jocel1/hotfix-PSCSX-6942
b6126cd 
[-] FO : Fix performances issue with SpecificPrice (PSCSX-6942)
//Fix d81b70a - category must be an object, not an array
21ba323
@julienbourdeau
Merge pull request PrestaShop#4325 from maximebiloe/1.6.1.x
b868dfb 
//Fix d81b70a - category must be an object, not an array
@tchauviere
// HELPER: Add brackets to multiple select name field
d030025 
Follow up 470b97c
@julienbourdeau
Merge pull request PrestaShop#4324 from tchauviere/fix/helper-multipl…
f950f8b 
…e-select

// HELPER: Add brackets to multiple select name field
@gRoussac
[*] CORE : SpecificPriceRule without conditions to id_product 0 inste…
107091c 
…ad of full products list
Merge pull request PrestaShop#4171 from gRoussac/specif-f
dff7548 
[*] CORE : SpecificPriceRule without conditions to id_product 0 instead of full products list
@julienbourdeau
Merge pull request PrestaShop#4248 from gRoussac/PSCSX-7021
9f692c6 
[*] BO : Add versioning to addJS to renew admin.js
@gRoussac @julienbourdeau
[*] BO : #PSCFV-12359 #PSCSX-1257 product tab async loading
68d052a
@julienbourdeau
// CORE: Only clean compare_product table if entry older than 1 week
d696628 
This commit 82c9dea introduce a bug,
the parameter passed to the function was ignored and
the table was cleaned all entries older than a week
Since the function have been working this way for 4 years, we
decided to not change the behavior and remove the parameter.
julienbourdeau and others added 8 commits October 23, 2015 17:05
@julienbourdeau
Merge pull request PrestaShop#4330 from PrestaShop/fix/slow-product-page
108442d 
[*] BO : #PSCFV-12359 #PSCSX-1257 product tab async loading
@Quetzacoalt91
Merge pull request PrestaShop#4331 from julienbourdeau/fix/comparePro…
6c53344 
…ductClearCache

// CORE: Only clean compare_product table if entry older than 1 week
@julienbourdeau
// Check PHP syntax error with travis
25fda84 
// update_eu_taxrulegroups.php avoid fatal in travis (php56)
@julienbourdeau
Merge pull request PrestaShop#4332 from julienbourdeau/fatal-travis
69a4db7 
[+] Check PHP syntax error with travis
@jocel1
[-] FO : Fix wrong date check in specific price (PSCSX-6942)
8b9ef15
Merge pull request PrestaShop#4350 from jocel1/hotfix-specificprice
99b5cf5 
[-] FO : Fix wrong date check in specific price
// Release 1.6.1.2
ce7bb3c
@studiokiwik
Performance is better when fetching all rows at once instead of itera…
2480e5d 
…ting over the result
@xBorderie
Copy link
Contributor

Hey @studiokiwik, thank you for remaking this PR on the develop branch!
Sadly, it seems that your codebase wasn't up-to-date, and several unrelated commits where included.
Could you remake it with an updated codebase?

Also, could you follow these title guidelines? http://doc.prestashop.com/display/PS16/How+to+write+a+commit+message

Thank you!

@julienbourdeau julienbourdeau self-assigned this Dec 9, 2015
@julienbourdeau
Copy link
Contributor

Hi,

Please update your PR and I'll merge it right away. Otherwise I'll have to cherry-pick your commit but the PR won't appear as merged. :(

@xBorderie
Copy link
Contributor

@julienbourdeau, the commit itself is 2480e5d, do you think it's mergeable easily? No risk of side-effect?

@julienbourdeau
Copy link
Contributor

Yeah it seems good to me and many peolple here #4368 :)

@xBorderie
Copy link
Contributor

Alright! Hey @studiokiwik, please update or remake your PR so you can get proper credit within the Git history :)

@xBorderie
Copy link
Contributor

Hey @mickaelandrieu, can you cherry-pick this one? Thanks!

Keeping it open until you have created your own PR.
Thank you for your contribution, @studiokiwik !

@xBorderie xBorderie added the Improvement Type: Improvement label Feb 16, 2016
@mickaelandrieu mickaelandrieu mentioned this pull request Feb 17, 2016
Closed
@maximebiloe
Copy link
Contributor

Hello,

The codebase is not up-to-date anymore and there more commits than needed in your PR.
The commit has been cherry-picked and redone here #5029 but the PR was closed.
Anyway, it has been backported in this one: #5106

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mickaelandrieu mickaelandrieu

Labels
Improvement Type: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet