Re-implement minimum purchase amount #5564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maximebiloe
commented
May 13, 2016
•
maximebiloe
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | In the BO you can set a minimum amount to purchase but it wasn't tae into account in FO. Now we disable the checkout button in shopping cart and also display a warning. We prevent to access to the checkout too by redirecting to the shopping cart. |
| Type? | bug fix |
| Category? | FO |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | http://forge.prestashop.com/browse/BOOM-120 |
| How to test? | Set a minimum amount to purchase in the BO, then try to order and check the behavior. |
maximebiloe
changed the title
| @@ -213,6 +213,7 @@ public function present($cart) | |||
| $products = $this->addCustomizedData($products, $cart); | |||
| $subtotals = []; | |||
|
|
|||
| $productsTotalExcludingTax = $cart->getOrderTotal(false, Cart::ONLY_PRODUCTS); | |||
| $total_excluding_tax = $cart->getOrderTotal(false); | |||
There was a problem hiding this comment.
some times we use _, sometimes camelCase, is it going to by standarized somehow?
There was a problem hiding this comment.
yes, now it's camelCase. We will change all old snake case legacy code, every time we can, smoothly.
There was a problem hiding this comment.
maximebiloe
added
waiting for code review
Waiting for QA
dSkrbic
added
QA ✔️
| $this->translator->trans( | ||
| 'A minimum shopping cart total of %s (tax excl.) is required to validate your order. | ||
| Current cart total is %s (tax excl.).', | ||
| [], |
|
Thank you @maximebiloe |
| $this->priceFormatter->convertAndFormat($minimalPurchase), | ||
| $this->priceFormatter->convertAndFormat($productsTotalExcludingTax) | ||
| ) : | ||
| '', |
There was a problem hiding this comment.
Just an idea right now…
As the PSR / Symfony do not control the ternary operator structure, maybe we should follow the AirBnb one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.