BO: Easier way to go to Maintenance page while shop is turned off #5612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -308,8 +308,9 @@ | |||
| {if isset($maintenance_mode) && $maintenance_mode == true} | |||
| <span class="shop-state" id="maintenance-mode"> | |||
| <i class="material-icons">build</i> | |||
| <span class="label-tooltip" data-toggle="tooltip" data-placement="bottom" data-html="true" | |||
| title="<p class='text-left text-nowrap'><strong>{l s='Your shop is in maintenance.'}</strong></p><p class='text-left'>{l s='Your visitors and customers cannot access your shop while in maintenance mode.%s To manage the maintenance settings, go to Preferences > Maintenance.' sprintf='<br />'}</p>">{l s='Maintenance mode'}</span> | |||
| <a class="label-tooltip" data-toggle="tooltip" data-placement="bottom" data-html="true" | |||
There was a problem hiding this comment.
except if I'm wrong, paragraph element is not allowed in a link
There was a problem hiding this comment.
paragraph in span is also not a good idea but this paragraph is only for a tooltip, right?
There was a problem hiding this comment.
agree with you paragraph in span is also a bad idea :/ let's validate product interest with @vincentbz before any git update, I dont want you to work for nothing :)
|
Definitively a feature I agree with :) Can you take a look @vincentbz ? |
mickaelandrieu
added
the
Waiting for QA
vincentbz
added
QA ✔️
|
Hi @kpodemski , Thanks for this PR. I just need to test if there is no conflict with another PR made by our team. |
vTerenti
added
QA ✔️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important guidelines