Bring product features in quickview when combinations exist #5975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Quetzacoalt91
commented
Aug 9, 2016
Quetzacoalt91
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | Bring the feature available on the product page when the customer select another combination (Page update ...) |
| Type? | bug fix |
| Category? | FO |
| BC breaks? | Nope |
| Deprecations? | Nope |
| Fixed ticket? |
|
| How to test? | On a product quickview, you should not have to click 10 times before another color is selected. Choosing another combination must update the quickview content (Images, availability, price etc.) |
|
Tested and ok, thanks ! |
|
thanks @Quetzacoalt91 |
| {block name='product_variants'} | ||
| {include file='catalog/_partials/product-variants.tpl'} | ||
| {/block} | ||
|
|
||
| {block name='product_add_to_cart'} | ||
| {include file='catalog/_partials/product-add-to-cart.tpl'} | ||
| {/block} | ||
|
|
||
| {block name='product_refresh'} | ||
| <input class="product-refresh" data-url-update="false" name="refresh" type="submit" value="{l s='Refresh' d='Shop.Theme.Actions'}" hidden> |
There was a problem hiding this comment.
Is the hidden as an attribute wanted?
There was a problem hiding this comment.
Yes, the JS file checks the existence of this input in the DOM in order to launch the auto refresh, but the customer won't need to interact with it directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.