Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zipcode formats for Afghanistan and Egypt #6159

Merged
merged 1 commit into from
Oct 12, 2016

Conversation

enumag
Copy link
Contributor

@enumag enumag commented Sep 3, 2016

Questions Answers
Branch? 1.6.1.x
Description? Add zipcode formats for Afghanistan and Egypt
Type? bug fix
Category? IN
BC breaks? no
Deprecations? no
Fixed ticket?
How to test?

Source: https://en.wikipedia.org/wiki/List_of_postal_codes

@xBorderie
Copy link
Contributor

Thank you for this PR!

Could you amend your commits' names to use the guidelines, so that it is taken into account by our changelog tool?

To do this, open a command line window and use git commit --amend for the commit's name. See GitHub's help page for more information.

Note: this must be done via the command line: you can't do this just by changing the title of the pull-request from the GitHub interface! :)

Thank you!

@enumag
Copy link
Contributor Author

enumag commented Sep 11, 2016

@xBorderie Done.

@xBorderie
Copy link
Contributor

Thank you!

@julienbourdeau
Copy link
Contributor

I have reported your patch on develop branch, this should be merged for the next 1.6 version.
thank you for your contribution!

@maximebiloe maximebiloe changed the title [IN] Add zipcode formats Add zipcode formats for Afghanistan and Egypt Oct 12, 2016
@maximebiloe maximebiloe merged commit b8e8f83 into PrestaShop:1.6.1.x Oct 12, 2016
@maximebiloe
Copy link
Contributor

Thank you @enumag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants