Combination feature desactivation #6208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Return if Feature feature is active or not | ||
| * @return bool | ||
| */ | ||
| public function featureIsActive() |
There was a problem hiding this comment.
Except if I'm wrong, it's not used, right ?
There was a problem hiding this comment.
No, it's not used for the moment. As I was working on combinaison and feature, I make 2 functions
|
Tested and ok, thanks ! No combination possible when option is disabled The attribute page is disabled too |
mickaelandrieu
added
the
Waiting for author
| 'desc' => $this->trans('Add new feature', array(), 'Admin.Catalog.Feature'), | ||
| 'icon' => 'process-icon-new' | ||
| ); | ||
| if (Feature::isFeatureActive()) { |
There was a problem hiding this comment.
It's not really the same :
- sometimes $this->display == 'something', sometimes empty($this->display)
- Combination:: vs Feature::
mickaelandrieu
removed
the
Waiting for author
|
Thank you @aleeks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "combination" bloc on "new product" page
- Go to "attributes & features tabs", test if is ok with settings,
- Go on "new product" page and see "declinaison bloc" on the right is active or not