Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Category class + cleanup #6209

Merged
merged 1 commit into from Sep 7, 2016

Conversation

@firstred
Copy link
Contributor

commented Sep 7, 2016

Questions Answers
Branch? develop
Description? Upgrading the PHPDoc comments of this class, using the latest PS standards and also applying the PS standards to some of the code. Also getting the Franglais out of the comments, getting rid of things the Symfony code sniffer nags about, etc. It might have some additional todo tags, depending on whether the code was comprehensible or not.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? N/A

Warning: this PR also has a code cleanup. Please check this first before merging!

@firstred firstred changed the title CO: Document Category class + cleanup Document Category class + cleanup Sep 7, 2016

@mickaelandrieu

This comment has been minimized.

Copy link
Member

commented Sep 7, 2016

985 additions, 586 deletions not shown because the diff is too large. Please use a local Git client to view these changes.

:(

@firstred

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2016

gitk to the rescue 😄

@firstred

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2016

But I indeed have changed a lot. This is basically what I would like to see with every class/controller file before 1.7 gets released.

Having good documentation, add @deprecate tags to unncessary stuff and fully up to date with Symfony style. This should eventually save a lot of people a lot of time.

@mickaelandrieu

This comment has been minimized.

Copy link
Member

commented Sep 7, 2016

👍 ok to me !

@mickaelandrieu mickaelandrieu merged commit b2ebcbd into PrestaShop:develop Sep 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@firstred

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2016

Damn you did a lot of work in a short amount of time.

Great job! 🎉

@mickaelandrieu

This comment has been minimized.

Copy link
Member

commented Sep 7, 2016

I've rode only "your" file, not the diff :p

@firstred

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2016

Nice. The rest should be easier (I hope) as those classes are smaller.

@mickaelandrieu

This comment has been minimized.

Copy link
Member

commented Sep 7, 2016

And obviously, this huge PR broke something :(

@firstred

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2016

Good to know. I'll go check it.

@mickaelandrieu

This comment has been minimized.

Copy link
Member

commented Sep 7, 2016

#6212 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.