Document Category class + cleanup

[firstred]

Questions	Answers
Branch?	develop
Description?	Upgrading the PHPDoc comments of this class, using the latest PS standards and also applying the PS standards to some of the code. Also getting the Franglais out of the comments, getting rid of things the Symfony code sniffer nags about, etc. It might have some additional todo tags, depending on whether the code was comprehensible or not.
Type?	improvement
Category?	CO
BC breaks?	no
Deprecations?	no
Fixed ticket?	N/A
How to test?	N/A

Warning: this PR also has a code cleanup. Please check this first before merging!

[mickaelandrieu]

985 additions, 586 deletions not shown because the diff is too large. Please use a local Git client to view these changes.

:(

[firstred]

gitk to the rescue 😄

[firstred]

But I indeed have changed a lot. This is basically what I would like to see with every class/controller file before 1.7 gets released.

Having good documentation, add @deprecate tags to unncessary stuff and fully up to date with Symfony style. This should eventually save a lot of people a lot of time.

[mickaelandrieu]

👍 ok to me !

[firstred]

Damn you did a lot of work in a short amount of time.

Great job! 🎉

[mickaelandrieu]

I've rode only "your" file, not the diff :p

[firstred]

Nice. The rest should be easier (I hope) as those classes are smaller.

[mickaelandrieu]

And obviously, this huge PR broke something :(

[firstred]

Good to know. I'll go check it.

[mickaelandrieu]

#6212 :)