New keyboard shortcut in product page #6675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonBot
added
the
Waiting for wording
|
Test Q&A OK |
|
We need to rebase @AntoineMille See with you this afternoon! |
AntoineMille
force-pushed
the
new_keyboard
branch
from
2d27309
to
52bdb70
Compare
AlexEven
removed
the
Waiting for wording
aleeks
reviewed
Oct 14, 2016
| /** create keyboard event for save & active or desactive product*/ | ||
| jwerty.key('ctrl+O', function(e) { | ||
| e.preventDefault(); | ||
| if ($('#form_step1_active').prop('checked') == true) |
There was a problem hiding this comment.
Why not just :
var step1Checkbox = $('#form_step1_active');
step1Checkbox.prop('checked', !step1Checkbox.is(':checked'));
There was a problem hiding this comment.
It's update. Thanks
| /** create keyboard event for save & go preview */ | ||
| jwerty.key('ctrl+V', function(e) { | ||
| e.preventDefault(); | ||
| send($('.product-footer .preview').attr('data-redirect'), $('.product-footer .preview').attr('target')); |
There was a problem hiding this comment.
Why not ? : (ping other, i'm not sure)
var productFooter = $('.product-footer .preview');
send(productFooter.attr('data-redirect'), productFooter.attr('target'));
There was a problem hiding this comment.
I'm agree with you to use var.
|
Thank you for your changes, i'm waiting test :) ! |
prestonBot
added
Waiting for wording
xBorderie
added
QA ✔️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every detail helps: versions, browser/server configuration, specific module/theme, etc.