Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sort by text display #7160

Merged
merged 1 commit into from
Dec 5, 2016
Merged

Fix sort by text display #7160

merged 1 commit into from
Dec 5, 2016

Conversation

antoin-m
Copy link
Contributor

@antoin-m antoin-m commented Dec 5, 2016 •
edited
Loading

Questions Answers
Branch? 1.7.0.x
Description? The "sort by" text on the category page shouldn't get under the dropdown when it's too long
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-1970
How to test?

Before:
before-sort-by

After:
after-sort-by

maximebiloe
maximebiloe suggested changes Dec 5, 2016
View reviewed changes
themes/classic/assets/js/theme.js
@@ -10004,7 +10004,7 @@
/* 6 */
/***/ function(module, exports, __webpack_require__) {

var __WEBPACK_AMD_DEFINE_FACTORY__, __WEBPACK_AMD_DEFINE_RESULT__;/*! tether 1.3.8 */
var __WEBPACK_AMD_DEFINE_FACTORY__, __WEBPACK_AMD_DEFINE_RESULT__;/*! tether 1.3.7 */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little npm update to avoid regression, please?

@maximebiloe maximebiloe changed the base branch from 1.7.0.x to develop December 5, 2016 15:02
@maximebiloe maximebiloe changed the base branch from develop to 1.7.0.x December 5, 2016 15:02
@maximebiloe maximebiloe added this to the 1.7.0.3 milestone Dec 5, 2016
@maximebiloe maximebiloe changed the title Fix sort by text Fix sort by text display Dec 5, 2016
@maximebiloe maximebiloe merged commit ddabc71 into PrestaShop:1.7.0.x Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximebiloe maximebiloe maximebiloe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@antoin-m @maximebiloe