Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter currency name to varchar(64) #7418

Merged
merged 1 commit into from Jan 30, 2017

Conversation

@antoin-m
Copy link
Contributor

commented Jan 30, 2017

Questions Answers
Branch? 1.7.0.x
Description? Some currencies have a name that are too long to fit in the DB.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-2170
How to test? Try to add the 'Bosnia-Herzegovina Convertible Mark (BAM)' currency.

Ping @aleeks @maximebiloe
Since it alters a table in the database maybe we should wait for 1.7.1.0?

@antoin-m antoin-m closed this Jan 30, 2017

@antoin-m antoin-m force-pushed the antoin-m:fix/currency-name branch from ef943ef to 4689442 Jan 30, 2017

@antoin-m antoin-m reopened this Jan 30, 2017

@dSkrbic dSkrbic added the QA ✔️ label Jan 30, 2017

@dSkrbic

This comment has been minimized.

Copy link
Contributor

commented Jan 30, 2017

Test Q&A OK :)

@aleeks aleeks added this to the 1.7.0.5 milestone Jan 30, 2017

@aleeks

This comment has been minimized.

Copy link
Contributor

commented Jan 30, 2017

Thank you @antoin-m

@aleeks aleeks merged commit 3d14bdc into PrestaShop:1.7.0.x Jan 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aleeks aleeks deleted the antoin-m:fix/currency-name branch Jan 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.