Use default state for tax purposes #7482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleeks
added
the
Waiting for QA
|
Problem is that Address:Initialize is not used everywhere and some classes initialize adress by their own and don't use the default state. |
|
Hello @cedricfontaine, do you mean this fix isn't working ? |
|
Well it's working but it's not enough in the latest code. |
In countries with two level of taxes, it is interesting to give an estimate of taxes based on the shop location and applying also the state tax.
|
Rebased to be like Shop.php https://github.com/PrestaShop/PrestaShop/blob/develop/classes/shop/Shop.php#L471 |
aleeks
removed
the
Waiting for QA
|
Thank you @aleeks @cedricfontaine 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In countries with two level of taxes, it is interesting to give an estimate of taxes based on the shop location and applying also the state tax.
See: #4415