Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing reference symbol into Product::getProductProperties #7589

Merged
merged 1 commit into from Mar 6, 2017
Merged

Fix missing reference symbol into Product::getProductProperties #7589

merged 1 commit into from Mar 6, 2017

Conversation

hadjedjvincent
Copy link
Contributor

Questions Answers
Branch? develop
Description? Allow Product::getProductProperties to be used correctly
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
How to test? Just try to edit something from "product" hook parameter, it will only work if you use this fix

@xBorderie
Copy link
Contributor

I like how your whole team is cheering for you :)

@aleeks
Copy link
Contributor

aleeks commented Feb 23, 2017

Make sense to me

@aleeks
Copy link
Contributor

aleeks commented Feb 23, 2017

Thank you @hadjedjvincent

@prestamodule
Copy link
Contributor

prestamodule commented Feb 27, 2017 •
edited

@aleeks any chance to get this merged for 1.7.0.6 ? Thx
Or for 1.7.1.0 ? @xBorderie @Shudrum

@prestamodule
Copy link
Contributor

Hey @aleeks, any news about this fix please ? cc @xBorderie

@Quetzacoalt91
Copy link
Member

Hello guys,

If you want to make this fix available on PS versions 1.7.1.x (this is too late for 1.7.0.6), you have to change the base branch. The branch develop contains changes for 1.7.2.x.

@Quetzacoalt91 Quetzacoalt91 changed the title CO: Fix missing reference symbol into Product::getProductProperties Fix missing reference symbol into Product::getProductProperties Mar 6, 2017
@hadjedjvincent hadjedjvincent changed the base branch from develop to 1.7.1.x March 6, 2017 16:22
@hadjedjvincent
Copy link
Contributor Author

@Quetzacoalt91 Updated now. BTW, too bad that @aleeks did not merged this 11 days ago as this was ready already.
Anyway, now, we have to make our PR using 1.7.1.x branch instead of develop ?

@Quetzacoalt91
Copy link
Member

If we deal with a bug fix, yes. develop is also possible but this would make the fix only available from 1.7.2.x.

@Quetzacoalt91 Quetzacoalt91 merged commit e6accb4 into PrestaShop:1.7.1.x Mar 6, 2017
@Quetzacoalt91
Copy link
Member

@hadjedjvincent and all your team, thank you.

@xBorderie xBorderie added this to the 1.7.1.0 milestone Mar 6, 2017
@prestonBot prestonBot mentioned this pull request Mar 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrestaEdit PrestaEdit PrestaEdit approved these changes

@aleeks aleeks aleeks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.1.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hadjedjvincent @xBorderie @aleeks @prestamodule @Quetzacoalt91 @PrestaEdit