Fix line endings in theme's JS files

[mcdado]

Questions	Answers
Branch?	1.6.1.x
Description?	Fix line endings in JavaScript theme files.
Type?	bug fix
Category?	FO
BC breaks?	no
Deprecations?	no
How to test?	Check out the files and verify the line endings, they should be LF instead of CRLF.

[xBorderie]

Thanks! Are you sure your indentation is correct? 'cos I need to point to https://github.com/PrestaShop/PrestaShop/pull/7607/files?w=1 :)

[mcdado]

Well… I didn't want to put too many style corrections into this PR. All .js theme files are tab indented, I just followed that, and I don't think I made indentation mistakes, right? Otherwise let me know where exactly and I'll correct it, as usual.

That said, I had to correct the line endings because I have a big heart! ❤️ 😉

[mcdado]

I would gladly make a PR with an eslint run of all js files in the theme directory. Let me know! if that's be okay.

[Quetzacoalt91]

Hello @mcdado,

What error are you trying to fix ? I tried to reproduce the initial problem but unfortunately nothing is reported in the console on this page.

[mcdado]

Line 410 of global.js is as follows in my current theme:
$.totalStorage('display', 'list');

Actually, now that I think of it, I didn't test it against current default theme, since we have a theme that is based on it, I thought it couldn't be too different since we generally pull upstream patches. Can you try to force running bindGrid() from global.js and see if that causes errors to you?

[Quetzacoalt91]

Hello,

On the default theme, the function bindGrid() handles properly the non-existing storage and returns before executing anything related to the view:

function bindGrid()
{
    console.log('bindGrid() called');
	var storage = false;
	if (typeof(getStorageAvailable) !== 'undefined') {
		storage = getStorageAvailable();
	}
	if (!storage) {
		return; // <- returns here
	}

Console output:

[mcdado]

That's right, it was already implemented… 6528fe9

Well, then let me amend my commits and do just the line ending fixes

[mcdado]

Okay I deleted the extra change, now it's only linde endings.

[Quetzacoalt91]

All right, this PR can now be merged.

[mcdado]

Rebased on top of 1.6.1.x.

[xBorderie]

Cheers David! 🎉

[maximebiloe]

Thank you @mcdado