Allow to define module front controllers layout

[tonyyb]

Re-open : #7771 with good convention name.

Questions	Answers
Branch	1.7.x
Description?	Currently it is not possible to define the layout of a module front controller.
Type?	improvement
Category?	FO
BC breaks?	no
Deprecations?	no
Fixed ticket?	-
How to test?	Try to define the layout of a module from AdminThemes back office controller.

[prestonBot]

Hello tonyyb!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

[xBorderie]

👍

[Quetzacoalt91]

Hello @tonyyb,

What do you think if we just use $this->getPageName()?

$entity = $this->php_self;
if (empty($entity)) {
    $entity = $this->getPageName();
}

It seems to handle even more cases:

    public function getPageName()
    {
        // Are we in a payment module
        $module_name = '';
        if (Validate::isModuleName(Tools::getValue('module'))) {
            $module_name = Tools::getValue('module');
        }

        if (!empty($this->page_name)) {
            $page_name = $this->page_name;
        } elseif (!empty($this->php_self)) {
            $page_name = $this->php_self;
        } elseif (Tools::getValue('fc') == 'module' && $module_name != '' && (Module::getInstanceByName($module_name) instanceof PaymentModule)) {
            $page_name = 'module-payment-submit';
        } elseif (preg_match('#^'.preg_quote($this->context->shop->physical_uri, '#').'modules/([a-zA-Z0-9_-]+?)/(.*)$#', $_SERVER['REQUEST_URI'], $m)) {
            // @retrocompatibility Are we in a module ?
            $page_name = 'module-'.$m[1].'-'.str_replace(array('.php', '/'), array('', '-'), $m[2]);
        } else {
            $page_name = Dispatcher::getInstance()->getController();
            $page_name = (preg_match('/^[0-9]/', $page_name) ? 'page_'.$page_name : $page_name);
        }

        return $page_name;
    }

[xBorderie]

Hey @tonyyb ! What do you think of @Quetzacoalt91 's suggestion above?

[tonyyb]

Hi @xBorderie @Quetzacoalt91 : I think that's a good idea ! 👍

[xBorderie]

Thank you!

Could you try and squash those commits into just one? Another explanation of squashing.

[Quetzacoalt91]

This is okay to keep the history like this @xBorderie, that's why I merge it. ;)

Thanks @tonyyb.

[xBorderie]

Fine by me :)