CategoryController - Show page 404 with an error instead of redirecting to the 404 #8092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GuillaumeGBzh
commented
Jul 5, 2017
GuillaumeGBzh
commented
| Questions | Answers |
|---|---|
| Branch? | 1.6.1.x |
| Description? | When I view page of a category that does not exist, I am redirected to page 404 rather than displaying an error and a 404 code. I was inspired by the behavior of the 404 on the products. |
| Type? | bug fix |
| Category? | FO |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | (optional) |
| How to test? | View a category that does not exist. Example: index.php?id_category=999999&controller=category |
…ecting to the 404
|
Hello GuillaumeG22! This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community! |
maximebiloe
approved these changes
Jul 13, 2017
maximebiloe
changed the title
|
Thanks @GuillaumeG22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.