Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Japanese to the installer #8299

Merged
merged 1 commit into from
Sep 4, 2017
Merged

Adding Japanese to the installer #8299

merged 1 commit into from
Sep 4, 2017

Conversation

AlexEven
Copy link
Contributor

@AlexEven AlexEven commented Sep 1, 2017 •
edited by aleeks
Loading

Questions Answers
Branch? develop
Description? Adding Japanese as an available language in the installer.
Type? new feature
Category? IN
BC breaks? no
Deprecations? no
Fixed ticket? n/a.
How to test? Install and see if Japanese is available as an installation language.

@AlexEven AlexEven added this to the 1.7.3.0 milestone Sep 1, 2017
@aleeks
Copy link
Contributor

aleeks commented Sep 1, 2017 •
edited by xBorderie
Loading

Code looks like ok, we don't have images in japanese?

@AlexEven
Copy link
Contributor Author

AlexEven commented Sep 4, 2017 •
edited
Loading

Because I don't speak Japanese and this is not a priority.
Many languages have the defaut English images unfortunately.

@aleeks
Copy link
Contributor

aleeks commented Sep 4, 2017

Thank you @AlexEven

@aleeks aleeks merged commit ff209df into PrestaShop:develop Sep 4, 2017
@AlexEven AlexEven mentioned this pull request Sep 15, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleeks aleeks aleeks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexEven @aleeks