New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add paid order to stats dashboard even when there's no related invoice generated" #8335

Merged
merged 1 commit into from Sep 25, 2017

Conversation

Projects
None yet
3 participants
@eternoendless
Member

eternoendless commented Sep 14, 2017

Questions Answers
Branch? 1.6.1.x
Description? Reverts this PR #8116
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/PSCSX-9335
How to test?

The dashboard should show all orders that were switched to a "validated" state on a given date. Since that information is not stored in a way that is easily processed, and we cannot change the schema on 1.6.x, workarounds have been made which produce accurate results on most cases.

The reverted PR fixed a very specific case, but produced less accurate results on most other cases.

As we are unable to address the underlying problem on the 1.6.x branch, we'll have to fix it on 1.7.x

@hibatallahAouadni

This comment has been minimized.

Show comment
Hide comment
@hibatallahAouadni

hibatallahAouadni Sep 21, 2017

Contributor

@eternoendless this PR need to be merged the first, cause I've got other PR need to be rebased

Contributor

hibatallahAouadni commented Sep 21, 2017

@eternoendless this PR need to be merged the first, cause I've got other PR need to be rebased

@Quetzacoalt91 Quetzacoalt91 added this to the 1.6.1.18 milestone Sep 21, 2017

@eternoendless eternoendless merged commit 64e45aa into 1.6.1.x Sep 25, 2017

3 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@eternoendless eternoendless deleted the revert-8116-PSCSX-9094 branch Sep 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment