Revert "Add paid order to stats dashboard even when there's no related invoice generated" #8335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eternoendless
force-pushed
the
revert-8116-PSCSX-9094
branch
from
a4bc257
to
740ceed
Compare
…lated invoice generated"
eternoendless
force-pushed
the
revert-8116-PSCSX-9094
branch
from
740ceed
to
38ce2b1
Compare
|
@eternoendless this PR need to be merged the first, cause I've got other PR need to be rebased |
Quetzacoalt91
approved these changes
Sep 21, 2017
nbowlinger
added a commit
to nbowlinger/PrestaShop-1.6
that referenced
this pull request
Nov 7, 2020
invoice generated" #8335 PrestaShop/PrestaShop#8335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dashboard should show all orders that were switched to a "validated" state on a given date. Since that information is not stored in a way that is easily processed, and we cannot change the schema on 1.6.x, workarounds have been made which produce accurate results on most cases.
The reverted PR fixed a very specific case, but produced less accurate results on most other cases.
As we are unable to address the underlying problem on the 1.6.x branch, we'll have to fix it on 1.7.x