Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the spam protection option in the preference page #8420

Closed
wants to merge 2 commits into from

Conversation

Azouz-Jribi
Copy link
Contributor

@Azouz-Jribi Azouz-Jribi commented Oct 16, 2017

Questions Answers
Branch? 1.6.1.x
Description? We add the spam protection option in the preference page, if the option is activated then the spam protection solution proposed in this PR (#8168) will be applied
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/PSCSX-9466
How to test?

general prestashop 1 6


This change is Reviewable

@LittleBigDev LittleBigDev changed the title Add the spam protection option in the perference page Add the spam protection option in the preference page Nov 7, 2017
@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label Nov 7, 2017
@LittleBigDev LittleBigDev removed the Waiting for wording Status: action required, waiting for wording label Nov 7, 2017
@LittleBigDev
Copy link
Contributor

:lgtm:


Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@marionf marionf added the Waiting for QA Status: action required, waiting for test feedback label Feb 13, 2018
@marionf marionf added Waiting for wording Status: action required, waiting for wording QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Mar 12, 2018
@LouiseBonnard LouiseBonnard removed the Waiting for wording Status: action required, waiting for wording label Mar 13, 2018
@matks
Copy link
Contributor

matks commented Sep 12, 2019

@marionf if this issue is still happening in 1.7, we should be able to fix it thanks to this PR

Issue is: spam protection is mandatory, this PR allows merchant to choose to disable it

@marionf
Copy link
Contributor

marionf commented Sep 13, 2019

I think this PR is not necessary with what has already been done about spamming problems:
http://build.prestashop.com/news/fighting-against-spamming/
http://build.prestashop.com/news/fighting-against-spamming-again/

@matks
Copy link
Contributor

matks commented Sep 13, 2019

Then we can close it.

@matks matks closed this Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA ✔️ Status: check done, code approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants