Upgrade Symfony to 3.4 LTS #8515

mickaelandrieu · 2017-11-20T11:35:40Z

Questions	Answers
Branch?	develop
Description?	Symfony 3.4 LTS will be released on 30th of november, time to upgrade our deps!
Type?	improvement
Category?	BO
BC breaks?	no
Deprecations?	no
Forge issue?	http://forge.prestashop.com/browse/BOGOSS-90
How to test?	Tests should pass with an updated `composer.lock` file + "Clear Cache" action in Performance page should not break.

This change is

mickaelandrieu · 2017-11-20T11:36:15Z

composer.json

        "symfony-tests-dir": "tests",
        "symfony-assets-install": "relative",
        "incenteev-parameters": {
            "file": "app/config/parameters.yml"
        }
    },
-    "author": "PrestaShop",


for what it means, the "author" key is not allowed in Composer configuration => https://getcomposer.org/doc/04-schema.md#authors

mickaelandrieu · 2017-11-20T16:47:10Z

@jocel1 I don't know why the create-db command is broken: Symfony is looking for ::getDefaultName which exists :/

mickaelandrieu · 2017-11-21T14:07:55Z

Tests still don't pass, the build is green only because I don't have commited the composer.lock file

jocel1 · 2017-11-29T13:36:05Z

composer.json

@@ -128,7 +127,6 @@
            "PrestaShopBundle\\Install\\Upgrade::migrateSettingsFile",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::buildBootstrap",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::clearCache",
-            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::installAssets",


no more installAssets?

we never install assets, as we don't use web folder :)

Quetzacoalt91 · 2017-12-01T09:09:43Z

src/PrestaShopBundle/Resources/config/services.yml

@@ -7,6 +7,9 @@ parameters:
    prestashop.security.voter.product.class: PrestaShopBundle\Security\Voter\PageVoter

 services:
+    _defaults:
+        public: true
+


So you had to set it as default AND for each service?

only for them where Symfony cry a river, but it was not supposed to happen "in the book" :p

jocel1 · 2017-12-15T11:34:45Z

install-dev/index.php

@@ -36,6 +36,7 @@
 try {
    require_once(_PS_INSTALL_PATH_.'classes'.DIRECTORY_SEPARATOR.'controllerHttp.php');
    require_once(_PS_INSTALL_PATH_.'classes'.DIRECTORY_SEPARATOR.'HttpConfigureInterface.php');
+    dump(spl_autoload_functions ());die;


debug stuff ? :)

mickaelandrieu · 2017-12-15T13:17:48Z

@eternoendless I have an issue with "welcome" module installation... any hint?

Quetzacoalt91 · 2017-12-15T14:28:09Z

See 8b06534

mickaelandrieu · 2017-12-15T14:31:05Z

@Quetzacoalt91 so 1.7.3.x need to be merged into develop again, am I right?

mickaelandrieu · 2017-12-15T18:05:36Z

app/AppKernel.php

        if ('dev' === $this->getEnvironment()) {
            $bundles[] = new Symfony\Bundle\WebServerBundle\WebServerBundle();
        }

+        /**
+         * @see https://symfony.com/doc/2.8/configuration/external_parameters.html#environment-variables


~~needs to be removed~~ may be improved before release of 1.7.4

eternoendless · 2018-01-09T17:55:25Z

@alegout I choose you! ... to finish up this PR 😄

mickaelandrieu · 2018-01-12T23:38:00Z

@alegout I choose you! ... to finish up this PR 😄

If we're ok to skip the two related tests that can be covered by QA functional tests, there is nothing specific to the migration to finish: decision must be done here, also someone from QA team need to check if Stock Management part of back office still works as expected.

Good luck @alegout, don't hesitate to mail/slack me if you have some questions :)

mickaelandrieu · 2018-01-12T23:40:01Z

classes/Tools.php

-        $sf2Refresh = new Refresh($env);
-        $sf2Refresh->addCacheClear();
-        $ret = $sf2Refresh->execute();
+        $dir = _PS_ROOT_DIR_ . '/var/cache*/' . $env;


- _PS_ROOT_DIR_ . '/var/cache*/' . $env + _PS_ROOT_DIR_ . '/var/cache/' . $env

marionf · 2018-01-15T08:56:47Z

Hello @mickaelandrieu & @alegout

I have an issue with the installation

Quetzacoalt91 · 2018-01-19T15:22:18Z

Seen while running the bin/console. Enjoy @alegout 😄


In Configuration.php line 152:
                                                                         
  [Symfony\Component\Debug\Exception\ContextErrorException]              
  Notice: Use of undefined constant _DB_PREFIX_ - assumed '_DB_PREFIX_'  
                                                                         

Exception trace:
 ConfigurationCore::loadConfiguration() at /home/thomas/Documents/github/PrestaShop/classes/Configuration.php:206
 ConfigurationCore::get() at /home/thomas/Documents/github/PrestaShop/src/Adapter/Country/CountryDataProvider.php:61
 PrestaShop\PrestaShop\Adapter\Country\CountryDataProvider->getIsoCodebyId() at /home/thomas/Documents/github/PrestaShop/var/cache/dev/Container9gsikne/appDevDebugProjectContainer.php:1158
 Container9gsikne\appDevDebugProjectContainer->getPrestashop_Addons_ClientApiService() at /home/thomas/Documents/github/PrestaShop/var/cache/dev/Container9gsikne/appDevDebugProjectContainer.php:1182
 Container9gsikne\appDevDebugProjectContainer->getPrestashop_Core_Admin_DataProvider_AddonsInterfaceService() at /home/thomas/Documents/github/PrestaShop/var/cache/dev/Container9gsikne/appDevDebugProjectContainer.php:1196
 Container9gsikne\appDevDebugProjectContainer->getPrestashop_Core_Admin_DataProvider_ModuleInterfaceService() at /home/thomas/Documents/github/PrestaShop/var/cache/dev/Container9gsikne/appDevDebugProjectContainer.php:1289
 Container9gsikne\appDevDebugProjectContainer->getPrestashop_Module_ManagerService() at /home/thomas/Documents/github/PrestaShop/var/cache/dev/Container9gsikne/appDevDebugProjectContainer.php:1329
 Container9gsikne\appDevDebugProjectContainer->getPrestashop_Twig_Extension_AdminService() at /home/thomas/Documents/github/PrestaShop/var/cache/dev/Container9gsikne/appDevDebugProjectContainer.php:1566
 Container9gsikne\appDevDebugProjectContainer->getTwigService() at /home/thomas/Documents/github/PrestaShop/var/cache/dev/Container9gsikne/getTwig_Translation_ExtractorService.php:8
 require() at /home/thomas/Documents/github/PrestaShop/var/cache/dev/Container9gsikne/appDevDebugProjectContainer.php:917
 Container9gsikne\appDevDebugProjectContainer->load() at /home/thomas/Documents/github/PrestaShop/var/cache/dev/Container9gsikne/getTranslation_ExtractorService.php:11
 require() at /home/thomas/Documents/github/PrestaShop/var/cache/dev/Container9gsikne/appDevDebugProjectContainer.php:917
 Container9gsikne\appDevDebugProjectContainer->load() at /home/thomas/Documents/github/PrestaShop/var/cache/dev/Container9gsikne/getConsole_Command_TranslationDebugService.php:8
 require() at /home/thomas/Documents/github/PrestaShop/var/cache/dev/Container9gsikne/appDevDebugProjectContainer.php:917
 Container9gsikne\appDevDebugProjectContainer->load() at /home/thomas/Documents/github/PrestaShop/var/cache/dev/Container9gsikne/getConsole_CommandLoaderService.php:37
 Container9gsikne\appDevDebugProjectContainer->{closure}() at /home/thomas/Documents/github/PrestaShop/vendor/symfony/symfony/src/Symfony/Component/DependencyInjection/ServiceLocator.php:64
 Symfony\Component\DependencyInjection\ServiceLocator->get() at /home/thomas/Documents/github/PrestaShop/vendor/symfony/symfony/src/Symfony/Component/Console/CommandLoader/ContainerCommandLoader.php:37
 Symfony\Component\Console\CommandLoader\ContainerCommandLoader->get() at /home/thomas/Documents/github/PrestaShop/vendor/symfony/symfony/src/Symfony/Component/Console/Application.php:504
 Symfony\Component\Console\Application->has() at /home/thomas/Documents/github/PrestaShop/vendor/symfony/symfony/src/Symfony/Component/Console/Application.php:668
 Symfony\Component\Console\Application->all() at /home/thomas/Documents/github/PrestaShop/vendor/symfony/symfony/src/Symfony/Bundle/FrameworkBundle/Console/Application.php:119
 Symfony\Bundle\FrameworkBundle\Console\Application->all() at /home/thomas/Documents/github/PrestaShop/vendor/symfony/symfony/src/Symfony/Component/Console/Descriptor/ApplicationDescription.php:103
 Symfony\Component\Console\Descriptor\ApplicationDescription->inspectApplication() at /home/thomas/Documents/github/PrestaShop/vendor/symfony/symfony/src/Symfony/Component/Console/Descriptor/ApplicationDescription.php:76
 Symfony\Component\Console\Descriptor\ApplicationDescription->getCommands() at /home/thomas/Documents/github/PrestaShop/vendor/symfony/symfony/src/Symfony/Component/Console/Descriptor/TextDescriptor.php:194
 Symfony\Component\Console\Descriptor\TextDescriptor->describeApplication() at /home/thomas/Documents/github/PrestaShop/vendor/symfony/symfony/src/Symfony/Component/Console/Descriptor/Descriptor.php:55
 Symfony\Component\Console\Descriptor\Descriptor->describe() at /home/thomas/Documents/github/PrestaShop/vendor/symfony/symfony/src/Symfony/Component/Console/Helper/DescriptorHelper.php:69
 Symfony\Component\Console\Helper\DescriptorHelper->describe() at /home/thomas/Documents/github/PrestaShop/vendor/symfony/symfony/src/Symfony/Component/Console/Command/ListCommand.php:75
 Symfony\Component\Console\Command\ListCommand->execute() at /home/thomas/Documents/github/PrestaShop/vendor/symfony/symfony/src/Symfony/Component/Console/Command/Command.php:252
 Symfony\Component\Console\Command\Command->run() at /home/thomas/Documents/github/PrestaShop/vendor/symfony/symfony/src/Symfony/Component/Console/Application.php:956
 Symfony\Component\Console\Application->doRunCommand() at /home/thomas/Documents/github/PrestaShop/vendor/symfony/symfony/src/Symfony/Bundle/FrameworkBundle/Console/Application.php:83
 Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() at /home/thomas/Documents/github/PrestaShop/vendor/symfony/symfony/src/Symfony/Component/Console/Application.php:240
 Symfony\Component\Console\Application->doRun() at /home/thomas/Documents/github/PrestaShop/vendor/symfony/symfony/src/Symfony/Bundle/FrameworkBundle/Console/Application.php:71
 Symfony\Bundle\FrameworkBundle\Console\Application->doRun() at /home/thomas/Documents/github/PrestaShop/vendor/symfony/symfony/src/Symfony/Component/Console/Application.php:148
 Symfony\Component\Console\Application->run() at /home/thomas/Documents/github/PrestaShop/bin/console:28

list [--raw] [--format FORMAT] [-h|--help] [-q|--quiet] [-v|vv|vvv|--verbose] [-V|--version] [--ansi] [--no-ansi] [-n|--no-interaction] [-e|--env ENV] [--no-debug] [--id_shop [ID_SHOP]] [--id_shop_group [ID_SHOP_GROUP]] [--] [<command>] [<namespace>]

mickaelandrieu · 2018-03-08T08:43:37Z

tests are green, and I've managed to install/re-install successfully: can you review this pull request one more time @marionf please? :)

marionf · 2018-03-08T13:45:33Z

@mickaelandrieu

I have an issue when I try to clear the cache

mickaelandrieu · 2018-03-08T14:44:24Z

@marionf done! Just forgot 1 very old commit :)

marionf · 2018-03-08T16:45:52Z

Ok for me :)

eternoendless · 2018-03-12T16:43:12Z

🎉

mickaelandrieu commented Nov 20, 2017

View reviewed changes

Quetzacoalt91 added the waiting for tests to pass label Nov 20, 2017

mickaelandrieu added the WIP label Nov 20, 2017

mickaelandrieu changed the title ~~Updated Symfony deps to 3.4~~ [WIP] Updated Symfony deps to 3.4 Nov 21, 2017

mickaelandrieu added the 1.7.x Branch label Nov 23, 2017

mickaelandrieu added this to the 1.7.4.0 milestone Nov 27, 2017

mickaelandrieu changed the title ~~[WIP] Updated Symfony deps to 3.4~~ Upgrade Symfony to 3.4 LTS Nov 28, 2017

mickaelandrieu requested a review from jocel1 November 28, 2017 04:46

jocel1 reviewed Nov 29, 2017

View reviewed changes

PrestaShop deleted a comment Nov 30, 2017

Quetzacoalt91 reviewed Dec 1, 2017

View reviewed changes

Quetzacoalt91 mentioned this pull request Dec 5, 2017

Use official Smarty lib #8566

Merged

mickaelandrieu closed this Dec 7, 2017

mickaelandrieu reopened this Dec 7, 2017

PrestaShop deleted a comment Dec 7, 2017

PrestaShop deleted a comment Dec 15, 2017

jocel1 reviewed Dec 15, 2017

View reviewed changes

PrestaShop deleted a comment Dec 15, 2017

mickaelandrieu commented Dec 15, 2017

View reviewed changes

mickaelandrieu added the Waiting for QA Status: action required, waiting for test feedback label Dec 21, 2017

mickaelandrieu mentioned this pull request Dec 22, 2017

Added PrestaShop CMS symfony/thanks#25

Closed

marionf removed the Waiting for QA Status: action required, waiting for test feedback label Jan 10, 2018

eternoendless assigned alegout Jan 10, 2018

mickaelandrieu commented Jan 12, 2018

View reviewed changes

marionf added the Waiting for author Status: action required, waiting for author feedback label Jan 15, 2018

alegout assigned mickaelandrieu and unassigned alegout Mar 7, 2018

mickaelandrieu removed WIP Waiting for author Status: action required, waiting for author feedback labels Mar 8, 2018

mickaelandrieu added the Waiting for QA Status: action required, waiting for test feedback label Mar 8, 2018

marionf added Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Mar 8, 2018

marionf added QA ✔️ Status: check done, code approved and removed Waiting for author Status: action required, waiting for author feedback labels Mar 8, 2018

mickaelandrieu added 2 commits March 12, 2018 16:26

CO: updated Symfony to 3.4

2d855c6

CO: fixed clear cache call

29c8905

eternoendless approved these changes Mar 12, 2018

View reviewed changes

eternoendless merged commit e8840f0 into PrestaShop:develop Mar 12, 2018

mickaelandrieu deleted the bogoss/sf3.4 branch March 12, 2018 16:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Symfony to 3.4 LTS #8515

Upgrade Symfony to 3.4 LTS #8515

mickaelandrieu commented Nov 20, 2017 •

edited

Loading

mickaelandrieu Nov 20, 2017

mickaelandrieu commented Nov 20, 2017

mickaelandrieu commented Nov 21, 2017

jocel1 Nov 29, 2017

mickaelandrieu Nov 30, 2017

Quetzacoalt91 Dec 1, 2017

mickaelandrieu Dec 7, 2017

jocel1 Dec 15, 2017

mickaelandrieu commented Dec 15, 2017

Quetzacoalt91 commented Dec 15, 2017

mickaelandrieu commented Dec 15, 2017

mickaelandrieu Dec 15, 2017 •

edited

Loading

eternoendless commented Jan 9, 2018

mickaelandrieu commented Jan 12, 2018

mickaelandrieu Jan 12, 2018

marionf commented Jan 15, 2018

Quetzacoalt91 commented Jan 19, 2018

mickaelandrieu commented Mar 8, 2018

marionf commented Mar 8, 2018

mickaelandrieu commented Mar 8, 2018

marionf commented Mar 8, 2018

eternoendless commented Mar 12, 2018

Upgrade Symfony to 3.4 LTS #8515

Upgrade Symfony to 3.4 LTS #8515

Conversation

mickaelandrieu commented Nov 20, 2017 • edited Loading

mickaelandrieu Nov 20, 2017

Choose a reason for hiding this comment

mickaelandrieu commented Nov 20, 2017

mickaelandrieu commented Nov 21, 2017

jocel1 Nov 29, 2017

Choose a reason for hiding this comment

mickaelandrieu Nov 30, 2017

Choose a reason for hiding this comment

Quetzacoalt91 Dec 1, 2017

Choose a reason for hiding this comment

mickaelandrieu Dec 7, 2017

Choose a reason for hiding this comment

jocel1 Dec 15, 2017

Choose a reason for hiding this comment

mickaelandrieu commented Dec 15, 2017

Quetzacoalt91 commented Dec 15, 2017

mickaelandrieu commented Dec 15, 2017

mickaelandrieu Dec 15, 2017 • edited Loading

Choose a reason for hiding this comment

eternoendless commented Jan 9, 2018

mickaelandrieu commented Jan 12, 2018

mickaelandrieu Jan 12, 2018

Choose a reason for hiding this comment

marionf commented Jan 15, 2018

Quetzacoalt91 commented Jan 19, 2018

mickaelandrieu commented Mar 8, 2018

marionf commented Mar 8, 2018

mickaelandrieu commented Mar 8, 2018

marionf commented Mar 8, 2018

eternoendless commented Mar 12, 2018

mickaelandrieu commented Nov 20, 2017 •

edited

Loading

mickaelandrieu Dec 15, 2017 •

edited

Loading