Fix pack stock issues

[alegout]

Questions	Answers
Branch?	1.7.3.x.
Description?	Fix issue with pack quantity.
Type?	bug fix
Category?	CO
BC breaks?	no
Deprecations?	no
Fixed ticket?	BOOM-4361, BOOM-3487
How to test?	1) in preferences > products > choose decrease both for packs 2) Don't allow to order out of stock product 3) create a product A with a stock of 50 4) create a product B with a stock of 5, this product is a pack of 10 products A 5) You cannot order 50 products A and 5 products B.

Important guidelines

• Make sure your local branch is up to date before commiting your changes!
• Your code MUST respect our Coding Standards (for code written in PHP, JavaScript, HTML/CSS/Smarty/Twig, SQL)!
• Your commit name MUST respect our naming convention!

---

This change is 

[LittleBigDev]

Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

---

src/PrestaShopBundle/Install/DatabaseDump.php, line 60 at r1 (raw file):

        if ($dumpFile === null) {
            $tmpDirPath = sys_get_temp_dir() . '/prestashop';

I think you didn't want to add this file in the commit ! Please make a separate PR for the DB dump fix.

---

src/PrestaShopBundle/Tests/Utils/Database.php, line 38 at r1 (raw file):

     * Create the initialize database used for test
     */
    public static function createTestDB($overrideIfExists = true)

I think you didn't want to add this file in the commit ! Please make a separate PR for the DB dump fix.

---

tests/TestCase/IntegrationTestCase.php, line 56 at r1 (raw file):

    {
        require_once(__DIR__ . '/../../config/config.inc.php');
        Database::restoreTestDB();

I think you didn't want to add this file in the commit ! Please make a separate PR for the DB dump fix.

---

Comments from Reviewable

[LittleBigDev]

Thank you @alegout
Please see my comments above

[alegout]

Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

src/PrestaShopBundle/Install/DatabaseDump.php, line 60 at r1 (raw file):

Previously, LittleBigDev (Bastien Bieri) wrote…

I think you didn't want to add this file in the commit ! Please make a separate PR for the DB dump fix.

Done.

---

src/PrestaShopBundle/Tests/Utils/Database.php, line 38 at r1 (raw file):

Previously, LittleBigDev (Bastien Bieri) wrote…

I think you didn't want to add this file in the commit ! Please make a separate PR for the DB dump fix.

Done.

---

tests/TestCase/IntegrationTestCase.php, line 56 at r1 (raw file):

Previously, LittleBigDev (Bastien Bieri) wrote…

I think you didn't want to add this file in the commit ! Please make a separate PR for the DB dump fix.

Done.

---

Comments from Reviewable

[LittleBigDev]

---

Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

---

Comments from Reviewable

[LittleBigDev]

Thank you @alegout 👍

[marionf]

Hello @alegout
If I add first 50 products A and try to add 5 packs B, I can't -> It's ok
But if I add first 5 packs B and try to add 50 products A, it works while it shouldn't

[jocel1]

Review status: 0 of 8 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

classes/Cart.php, line 1175 at r3 (raw file):

        if (Configuration::get('PS_ALLOW_MULTISHIPPING') && $this->isMultiAddressDelivery()) {
            $firstUnionSql .= ' AND cp.`id_address_delivery` = '.(int)$id_address_delivery;
            $secondUnionSql .= ' AND cp.`id_address_delivery` = '.(int)$id_address_delivery;

why not putting those in the commonWhere, and add the commonWhere later ?

---

classes/Cart.php, line 1180 at r3 (raw file):

        if ($id_customization) {
            $firstUnionSql .= ' AND c.`id_customization` = '.(int)$id_customization;
            $secondUnionSql .= ' AND c.`id_customization` = '.(int)$id_customization;

Same comment here, move it into the commonWhere

---

Comments from Reviewable

[jocel1]

Reviewed 8 of 8 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

Comments from Reviewable

[alegout]

Review status: 3 of 9 files reviewed at latest revision, 3 unresolved discussions.

---

classes/Cart.php, line 1175 at r3 (raw file):

Previously, jocel1 (Jocelyn Fournier) wrote…

why not putting those in the commonWhere, and add the commonWhere later ?

Done.

---

classes/Cart.php, line 1180 at r3 (raw file):

Previously, jocel1 (Jocelyn Fournier) wrote…

Same comment here, move it into the commonWhere

Done.

---

classes/Cart.php, line 1186 at r3 (raw file):

            COALESCE(SUM(first_level_quantity), 0) as quantity 
          FROM (' . $firstUnionSql . ' UNION ' . $secondUnionSql . ') as q';
        $result = Db::getInstance()->getRow($parentSql);

lulz

---

Comments from Reviewable

[eternoendless]

Reviewed 1 of 1 files at r9.
Review status: all files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.

---

Comments from Reviewable

[marionf]

@alegout
I choose to decrement pack only.
I add 5 products B & I try to add 50 products A -> I can, it's ok
I add 50 products A & I try to add 5 products B -> I can't, it's not ok It should be possible

[marionf]

It's ok for me, thanks you @alegout

[eternoendless]

Thank you @alegout 🎉