Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong usage of the query function #8748

Conversation

Azouz-Jribi
Copy link
Contributor

@Azouz-Jribi Azouz-Jribi commented Feb 9, 2018

Questions Answers
Branch? 1.6.1.x
Description? Wrong usage of the query function Db::getInstance()->query()
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test?

This change is Reviewable

@Quetzacoalt91
Copy link
Member

@Azouz-Jribi, what is the issue you try to solve here?
By looking at the code in Db::executeS(), it appears that setting the 2nd parameter as false make this called function only an alias for ... Db::query().

@Azouz-Jribi
Copy link
Contributor Author

Hi @Quetzacoalt91
I just duplicate this PR (#8417) on the 1.6, and already there is a PR (https://github.com/PrestaShop/blocklayered/pull/ 99) that solves the problem described in Jocel's PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants