Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dezipper redirect #8891

Merged
merged 1 commit into from
Mar 28, 2018
Merged

Fix dezipper redirect #8891

merged 1 commit into from
Mar 28, 2018

Conversation

eternoendless
Copy link
Member

@eternoendless eternoendless commented Mar 28, 2018 •
edited
Loading

Questions Answers
Branch? 1.7.3.x
Description? Sometimes the dezipper will want to stay in cache after the dezipping process, resulting in an error. This fix makes the dezipper explicitly redirect to the installer after it's done instead of reloading to avoid those issues.
Type? bug fix
Category? IN
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-5196
How to test? Create a build and test the unzipping process.

This change is Reviewable

@eternoendless eternoendless added this to the 1.7.3.1 milestone Mar 28, 2018
@Quetzacoalt91 Quetzacoalt91 added the Waiting for QA Status: action required, waiting for test feedback label Mar 28, 2018
@marionf marionf added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Mar 28, 2018
@Quetzacoalt91 Quetzacoalt91 merged commit 7281d73 into PrestaShop:1.7.3.x Mar 28, 2018
@Quetzacoalt91
Copy link
Member

Thank you @eternoendless

@eternoendless eternoendless deleted the fix-dezipper-cache branch April 3, 2018 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quetzacoalt91 Quetzacoalt91 Quetzacoalt91 approved these changes

Assignees
No one assigned
Labels
QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@eternoendless @Quetzacoalt91 @marionf