Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed template path #8912

Merged
merged 1 commit into from
Apr 3, 2018
Merged

Fixed template path #8912

merged 1 commit into from
Apr 3, 2018

Conversation

spolischook
Copy link
Contributor

@spolischook spolischook commented Apr 3, 2018 •
edited
Loading

Questions Answers
Branch? develop
Description? Fixed 500 on "Catalog -> Products" BO page after install
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? -
How to test? open "Catalog -> Products" page after install

This change is Reviewable

@prestonBot
Copy link
Collaborator

Hello spolischook!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot
Copy link
Collaborator

Hi!

Your pull request description seems to be incomplete or malformed:

  • The type should be one of: new feature, improvement, bug fix, refacto or critical.
  • The category should be one of: FO, BO, CO, IN, TE, WS, LO

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@spolischook
Copy link
Contributor Author

There should be tests that will check all pages at list for 200 response, isn't it?

@mickaelandrieu
Copy link
Contributor

@spolischook that something we are working on called "survival tests".

@mickaelandrieu mickaelandrieu merged commit 8776a4c into PrestaShop:develop Apr 3, 2018
@mickaelandrieu
Copy link
Contributor

Thanks @spolischook!

@spolischook spolischook deleted the patch-1 branch April 3, 2018 13:27
@eternoendless eternoendless added this to the 1.7.4.0 milestone Apr 13, 2018
@eternoendless eternoendless changed the title BO: Fixed template path Fixed template path Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickaelandrieu mickaelandrieu mickaelandrieu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@spolischook @prestonBot @mickaelandrieu @eternoendless