Make checkbox labels clickable on the classic theme #9110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the Identity page (and some other places), the checkbox labels are not clickable and the user needs to click only on the box itself in order to check it. This PR makes the label text also clickable, improving usability.
Quetzacoalt91
approved these changes
May 24, 2018
There was a problem hiding this comment.
Fine for me, bringing a nice improvement at the same time.
@eternoendless, does this seem valid to you?
eternoendless
approved these changes
May 28, 2018
eternoendless
changed the title
eternoendless
added
the
Waiting for QA
prasanthSelvar
added
QA ✔️
|
Thank you @rdy4ever |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the Identity page (and some other places), the checkbox labels are not clickable and the user needs to click only on the box itself in order to check it. This PR makes the label text also clickable, improving usability.
This change is