New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make checkbox labels clickable on the classic theme #9110

Merged
merged 1 commit into from May 29, 2018

Conversation

Projects
None yet
6 participants
@rdy4ever
Contributor

rdy4ever commented May 22, 2018

On the Identity page (and some other places), the checkbox labels are not clickable and the user needs to click only on the box itself in order to check it. This PR makes the label text also clickable, improving usability.

Questions Answers
Branch? develop
Description? On the Identity page (and some other places), the checkbox labels are not clickable and the user needs to click only on the box itself in order to check it. This PR makes the label text also clickable, improving usability.
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-5589
How to test?

This change is Reviewable

FO: Make checkbox lables clickable
On the Identity page (and some other places), the checkbox labels are not clickable and the user needs to click only on the box itself in order to check it. This PR makes the label text also clickable, improving usability.
@Quetzacoalt91

Quetzacoalt91 approved these changes May 24, 2018 edited

Fine for me, bringing a nice improvement at the same time.

@eternoendless, does this seem valid to you?

@eternoendless eternoendless changed the title from FO: Make checkbox labels clickable to Make checkbox labels clickable on the classic theme May 28, 2018

@eternoendless eternoendless added this to the 1.7.5.0 milestone May 28, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 242ac7b into PrestaShop:develop May 29, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented May 29, 2018

Thank you @rdy4ever

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment