Control if customer is the owner of the selected order in contact form #9126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank's |
|
@okom3pom Sorry for the delay, I was fighting with 1.6 on a recent debian install ^^ 1.7 is really easier to configure for me :) |
| * Check if customer select his order. | ||
| */ | ||
| if (!empty($id_order)) { | ||
| $order = new Order($id_order); |
There was a problem hiding this comment.
What happens if the order doesn't exist?
There was a problem hiding this comment.
Order information are empty. No error, and $order->id_customer will return null.
There was a problem hiding this comment.
I try with injecting 9999 maybe someone can try too :)
| */ | ||
| if (!empty($id_order)) { | ||
| $order = new Order($id_order); | ||
| $id_order = (int) $order->id_customer === (int) $customer->id ? $id_order : 0; |
There was a problem hiding this comment.
Be aware that this:
(int) $order->id_customer === (int) $customer->idIs basically equivalent to doing this:
$order->id_customer == $customer->idThere was a problem hiding this comment.
Even if I'm agree with you, I prefer cast to integer because it's an id =)
eternoendless
approved these changes
May 28, 2018
eternoendless
added
the
Waiting for QA
marionf
added
QA ✔️
|
Thank you @PierreRambaud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is