New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Apache Optimization #9244

Merged
merged 1 commit into from Aug 6, 2018

Conversation

Projects
None yet
7 participants
@Pedrock
Contributor

Pedrock commented Jul 1, 2018

Questions Answers
Branch? develop
Description? When Apache optimization is enabled in the CCC settings, the .htaccess is written as if the cache control was disabled
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? - Setup a shop
- Go to Advanced Parameters -> Performance and enable Apache optimization
- The browser should now be caching all asset files, including JS and CSS (the main .htaccess should include "ExpiresActive On" and a "ExpiresByType" for each file type)

This change is Reviewable

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Jul 1, 2018

Collaborator

Hello @Pedrock!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Jul 1, 2018

Hello @Pedrock!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot prestonBot added the 1.7.4.x label Jul 1, 2018

@mickaelandrieu mickaelandrieu changed the title from CO: Fix Apache Optimization to Fixed Apache Optimization Jul 3, 2018

@mickaelandrieu mickaelandrieu added the Bug label Jul 3, 2018

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Jul 24, 2018

Member

Thanks for the changes! Would you mind rebasing onto develop?

Member

eternoendless commented Jul 24, 2018

Thanks for the changes! Would you mind rebasing onto develop?

@Pedrock

This comment has been minimized.

Show comment
Hide comment
@Pedrock

Pedrock Jul 24, 2018

Contributor

@eternoendless Do you want me to rebase onto develop and change the target branch of the PR to develop or just to rebase onto 1.7.4.x since this is the current target branch of the PR?

Contributor

Pedrock commented Jul 24, 2018

@eternoendless Do you want me to rebase onto develop and change the target branch of the PR to develop or just to rebase onto 1.7.4.x since this is the current target branch of the PR?

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Jul 24, 2018

Member

Rebase into develop and change the target branch please.

Member

eternoendless commented Jul 24, 2018

Rebase into develop and change the target branch please.

@Pedrock Pedrock changed the base branch from 1.7.4.x to develop Jul 24, 2018

@Pedrock

This comment has been minimized.

Show comment
Hide comment
@Pedrock

Pedrock Jul 24, 2018

Contributor
Contributor

Pedrock commented Jul 24, 2018

@PierreRambaud PierreRambaud removed the 1.7.4.x label Jul 24, 2018

@eternoendless eternoendless added this to the 1.7.5.0 milestone Jul 27, 2018

@ntiepresta ntiepresta self-assigned this Jul 30, 2018

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Jul 30, 2018

@ntiepresta ntiepresta removed their assignment Jul 30, 2018

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Aug 6, 2018

Member

Travis ran properly, but sha1 don't match: https://travis-ci.org/PrestaShop/PrestaShop/builds/407597070

Merging.

Member

Quetzacoalt91 commented Aug 6, 2018

Travis ran properly, but sha1 don't match: https://travis-ci.org/PrestaShop/PrestaShop/builds/407597070

Merging.

@Quetzacoalt91 Quetzacoalt91 merged commit 986b628 into PrestaShop:develop Aug 6, 2018

1 check passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment