Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add combinations in cart summary #9252

Merged
merged 3 commits into from
Jul 5, 2018
Merged

Conversation

marionf
Copy link
Contributor

@marionf marionf commented Jul 3, 2018

Questions Answers
Branch? 1.7.4.X
Description? Add combinations in cart summary
Type? bug fix
Category? FO
BC breaks? No
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-5470
How to test? Create a product with many combinations & add it to the cart, click on details in the right column

Important guidelines


This change is Reviewable

@marionf marionf added this to the 1.7.4.1 milestone Jul 3, 2018
@@ -33,5 +33,12 @@
<span class="product-quantity">x{$product.quantity}</span>
<span class="product-price float-xs-right">{$product.price}</span>
{hook h='displayProductPriceBlock' product=$product type="unit_price"}
{foreach from=$product.attributes key="attribute" item="value"}
<div class="product-line-info product-line-info-secondary text-muted">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum you need to indent =)

Marion François and others added 2 commits July 3, 2018 12:33
@PierreRambaud PierreRambaud added Waiting for QA Status: action required, waiting for test feedback 1.7.4.x Branch labels Jul 3, 2018
@marionf marionf added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jul 3, 2018
@PierreRambaud
Copy link
Contributor

Thanks @marionf ;)

@PierreRambaud PierreRambaud merged commit 27f777c into PrestaShop:1.7.4.x Jul 5, 2018
@eternoendless eternoendless changed the title add combinations in cart summary Add combinations in cart summary Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.4.x Branch Bug Type: Bug QA ✔️ Status: check done, code approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants