-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Controller name for link generation to modules catalog #9261
Update Controller name for link generation to modules catalog #9261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo, the way we retrieve this link is different in modern pages, maybe in FrameworkAdminController
The issue asked to redirect to the module catalog instead of the module management page. If we have to deal with a popup instead, then the description original description is incomplete 🤔 |
aww I believe we wanted to have the same behavior on legacy and modern pages. But on legacy pages, you still have the poppin: wdyt @colinegin? |
I've just tried on PS 1.7.1.0, the modal is absent on symfony pages (= product page). |
ok then :) |
I approve, It resolve the bug |
Thanks @Quetzacoalt91 |
With MBO installed, if I click on "Recommanded modules" on a symfony page, I am well redirected to the "Module Catalog" tab but it is not selected @Quetzacoalt91 I don't know if it should be corrected in the Core or in the MBO module ? |
This change is