Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Controller name for link generation to modules catalog #9261

Merged

Conversation

Quetzacoalt91
Copy link
Member

@Quetzacoalt91 Quetzacoalt91 commented Jul 4, 2018

Questions Answers
Branch? 1.7.4.x
Description? With the new module controller links, the "Recommended modules" link wasn't redirecting the merchant to the catalog anymore.
Type? bug fix
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? http://forge.prestashop.com/browse/BOOM-5704
How to test? Click on recommended modules

This change is Reviewable

@prestonBot prestonBot added 1.7.4.x Branch Bug Type: Bug labels Jul 4, 2018
@mickaelandrieu
Copy link
Contributor

mickaelandrieu commented Jul 4, 2018

Hello,

in system information page, the link still redirect to modules page.

edit: same in Product pages

edit: in fact everytime we have this button

issue

it doesn't works.

Else, for pages with the "old" header it works

it_works

Copy link
Contributor

@mickaelandrieu mickaelandrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo, the way we retrieve this link is different in modern pages, maybe in FrameworkAdminController

@mickaelandrieu mickaelandrieu added this to the 1.7.4.1 milestone Jul 4, 2018
@Quetzacoalt91
Copy link
Member Author

Quetzacoalt91 commented Jul 4, 2018

The issue asked to redirect to the module catalog instead of the module management page. If we have to deal with a popup instead, then the description original description is incomplete 🤔

@mickaelandrieu
Copy link
Contributor

aww I believe we wanted to have the same behavior on legacy and modern pages.

But on legacy pages, you still have the poppin: wdyt @colinegin?

@Quetzacoalt91
Copy link
Member Author

I've just tried on PS 1.7.1.0, the modal is absent on symfony pages (= product page).
Adding a modal will not be done on this PR, as it seems we deal with a new feature.

@mickaelandrieu
Copy link
Contributor

ok then :)

@PierreRambaud PierreRambaud added QA ✔️ Status: check done, code approved Waiting for QA Status: action required, waiting for test feedback and removed QA ✔️ Status: check done, code approved labels Jul 5, 2018
@mbadrani mbadrani self-assigned this Jul 5, 2018
@mbadrani
Copy link
Contributor

mbadrani commented Jul 5, 2018

I approve, It resolve the bug

@mbadrani mbadrani added the QA ✔️ Status: check done, code approved label Jul 5, 2018
@PierreRambaud PierreRambaud merged commit e55a92d into PrestaShop:1.7.4.x Jul 5, 2018
@PierreRambaud
Copy link
Contributor

Thanks @Quetzacoalt91

@marionf
Copy link
Contributor

marionf commented Jul 5, 2018

With MBO installed, if I click on "Recommanded modules" on a symfony page, I am well redirected to the "Module Catalog" tab but it is not selected

capture d ecran_13

@Quetzacoalt91 I don't know if it should be corrected in the Core or in the MBO module ?

@mbadrani mbadrani removed their assignment Jul 24, 2018
@eternoendless eternoendless removed the Waiting for QA Status: action required, waiting for test feedback label Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.4.x Branch Bug Type: Bug QA ✔️ Status: check done, code approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants