New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PrestaTrust property with setter #9451

Merged
merged 3 commits into from Aug 24, 2018

Conversation

Projects
None yet
7 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Aug 15, 2018

Questions Answers
Branch? develop
Description? From a previous review, it was requested to remove a public property and add a setter instead.
Type? improvement
Category? BO
BC breaks? Property visibility changed
Deprecations? Nope
Fixed ticket? Fixed #10082
How to test? Modify your config.yml to disable PrestaTrust, and add a dump in the setter to check everything is properly set.

This change is Reviewable

@ntiepresta ntiepresta self-assigned this Aug 24, 2018

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Aug 24, 2018

@ntiepresta ntiepresta removed their assignment Aug 24, 2018

@mickaelandrieu mickaelandrieu merged commit 2c81d9b into PrestaShop:develop Aug 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 24, 2018

Contributor

Thanks @Quetzacoalt91 and everyone for review!

Contributor

mickaelandrieu commented Aug 24, 2018

Thanks @Quetzacoalt91 and everyone for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment