Rename function name to avoid conflicts while upgrading several modules in a row #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt75
approved these changes
May 18, 2020
PierreRambaud
previously approved these changes
May 19, 2020
|
Good to know that we can't update to modules containing upgrade functions with the same version 😂 |
|
yeah we figured that out at the same time :o Before merging this PR, line 43 should be modified. Can you please it as "Changes required"? |
Matt75
suggested changes
May 19, 2020
Progi1984
previously approved these changes
May 19, 2020
Quetzacoalt91
dismissed stale reviews from Progi1984 and PierreRambaud
via
7cfc3e6
Quetzacoalt91
force-pushed
the
rename-folder-autoupgrade
branch
from
a2b37c3
to
7cfc3e6
Compare
PierreRambaud
previously approved these changes
May 20, 2020
Progi1984
previously approved these changes
May 20, 2020
|
@Quetzacoalt91 Multiples relaunch for Travis but it seems that you have a problem. I try close/open. |
Matt75
previously approved these changes
May 20, 2020
Quetzacoalt91
dismissed stale reviews from Matt75, Progi1984, and PierreRambaud
via
8897e90
Quetzacoalt91
force-pushed
the
rename-folder-autoupgrade
branch
from
7cfc3e6
to
8897e90
Compare
|
PR has been rebased |
Progi1984
approved these changes
Mar 31, 2021
PierreRambaud
approved these changes
Mar 31, 2021
|
Thank you @Quetzacoalt91 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the feedback on the forum: https://www.prestashop.com/forums/topic/1023519-fatal-error-module-file/