Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stock movement DB employee fields #494

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

jolelievre
Copy link
Contributor

Questions Answers
Description? In the PR PrestaShop/PrestaShop#28640 a bug was detected related to employee with long name or firstname, it cause a bug while creating a stock movement because the stock_mvt structure can't handle such long values
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? ~
How to test? When upgrading from version prior ao 8.0.0 check the DB structure, in the stock_mvt table the columns employee_lastname and employee_lastname used to be VARCHAR(32) now they should be VARCHAR(255) to match the length from the employee table
Possible impacts? ~

@jolelievre jolelievre changed the title Update stock movement DB employee fields lnfgth Update stock movement DB employee fields Jun 20, 2022
MeKeyCool
MeKeyCool previously approved these changes Jul 4, 2022
atomiix
atomiix previously approved these changes Jul 7, 2022
matks
matks previously approved these changes Jul 11, 2022
@sLorenzini sLorenzini self-assigned this Jul 25, 2022
Copy link

@sLorenzini sLorenzini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jolelievre,

Thank you for this PR.
I've launched an autoupgrade from:

  • 1.7.6.9 to 8.0.0: database doesn't change (varchar(32) instead of varchar(255)) ❌
  • 1.7.7.8 to 8.0.0: database doesn't change (varchar(32) instead of varchar(255)) ❌
  • 1.7.8.6 to 8.0.0: database doesn't change (varchar(32) instead of varchar(255)) ❌

On Advanced Parameters > Database > Add new SQL query button
Capture d’écran 2022-07-25 à 17 11 38

On Phpmyadmin
Capture d’écran 2022-07-25 à 17 11 47

Create the 8.0.0 version file of upgrade with CreateRelease.php
SQL file in the module has the good change.
No error during the autoupgrade.

Did I miss something?

Thanks

@jolelievre
Copy link
Contributor Author

This PR is related to this core PR https://github.com/PrestaShop/PrestaShop/pull/28640/files

Which hasn't been merged yet for 8.0, and it should be delayed for 8.1 instead

@kpodemski
Copy link
Contributor

This needs rebase again :(

@Hlavtox
Copy link
Contributor

Hlavtox commented Feb 23, 2023

@jolelievre Rebase please, we need it for 8.1 release 🙏

@kpodemski kpodemski added this to the 4.16.0 milestone Mar 13, 2023
@kpodemski
Copy link
Contributor

thanks @jolelievre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants