-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stock movement DB employee fields #494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jolelievre,
Thank you for this PR.
I've launched an autoupgrade from:
- 1.7.6.9 to 8.0.0: database doesn't change (varchar(32) instead of varchar(255)) ❌
- 1.7.7.8 to 8.0.0: database doesn't change (varchar(32) instead of varchar(255)) ❌
- 1.7.8.6 to 8.0.0: database doesn't change (varchar(32) instead of varchar(255)) ❌
On Advanced Parameters > Database > Add new SQL query button
Create the 8.0.0 version file of upgrade with CreateRelease.php
SQL file in the module has the good change.
No error during the autoupgrade.
Did I miss something?
Thanks
This PR is related to this core PR https://github.com/PrestaShop/PrestaShop/pull/28640/files Which hasn't been merged yet for 8.0, and it should be delayed for 8.1 instead |
6fb8379
9061159
to
6fb8379
Compare
6fb8379
to
dcc6049
Compare
This needs rebase again :( |
@jolelievre Rebase please, we need it for 8.1 release 🙏 |
dcc6049
to
c65b5b2
Compare
thanks @jolelievre |
stock_mvt
structure can't handle such long valuesstock_mvt
table the columnsemployee_lastname
andemployee_lastname
used to beVARCHAR(32)
now they should beVARCHAR(255)
to match the length from the employee table