Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update product page feature flag values #562

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Update product page feature flag values #562

merged 3 commits into from
Apr 18, 2023

Conversation

jolelievre
Copy link
Contributor

@jolelievre jolelievre commented Feb 7, 2023 •
edited by MatShir
Loading

Questions Answers
Description? Update product page feature flag values and adapt the current state based on existing values
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#31381
Sponsor company ~
How to test? - When upgrading from 8.0.0 and product page V2 is enabled for single shop after the upgrade the product page should be enabled
- When upgrading from 8.0.0 and product page V2 is enabled for multi shop after the upgrade the product page should be enabled
- When upgrading from 8.0.0 and product page V2 is NOT enabled for single shop nor multi shop after the upgrade the product page should be disabled

In all three cases when you go to Experimental features, there is only one feature flag left for product page its name is now New product page and it's a stable feature so it's in the New features block

mflasquin
mflasquin previously approved these changes Feb 9, 2023
View reviewed changes
0x346e3730
0x346e3730 previously approved these changes Feb 13, 2023
View reviewed changes
@AureRita AureRita self-assigned this Feb 21, 2023
@HanaRebaiQA
Copy link

Hello @jolelievre

Thanks for your PR!
Your PR will fix this issue #31381 ?

@HanaRebaiQA HanaRebaiQA self-assigned this Feb 22, 2023
HanaRebaiQA
HanaRebaiQA reviewed Feb 22, 2023
View reviewed changes
Copy link

@HanaRebaiQA HanaRebaiQA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jolelievre

I have checked your PR. The improvement is NOK.

Here is my checked list :

  • Upgrade from PS8.0.1 to PS8.1.0 (From create release .zip) when multi shop enabled : NOK ❌
  • Upgrade from PS8.0.1 to PS8.1.0 (From create release .zip) when single shop enabled : NOK ❌ (Same error)
  • Upgrade from PS8.0.1 to PS8.1.0 (From create release .zip) when multi shop and single shop disabled : NOK ❌ (Same error)

==> After the upgrade is unsuccessful, the 8.1.0 shop is displayed but the Experimental features is incorrect.

image

upgrade.from.8.0.1.to.8.1.0._.NOK.mp4
  • Upgrade from PS8.0.1 to PS8.1.0_beta when multi shop enabled : NOK ❌ (Same error)
  • Upgrade from PS8.0.1 to PS8.1.0_beta when single shop enabled : NOK ❌ (Same error)
  • Upgrade from PS8.0.1 to PS8.1.0_beta when multi shop and single shop disabled : NOK ❌ (Same error)

image

  • Upgrade from PS1788 to PS8.1.0 (From create release .zip) when multi shop and single shop disabled: NOK ❌

image

Could you please check it ?

Thanks!

@HanaRebaiQA HanaRebaiQA removed their assignment Feb 22, 2023
@kpodemski kpodemski added this to the 4.16.0 milestone Mar 13, 2023
kpodemski
kpodemski reviewed Mar 16, 2023
View reviewed changes
upgrade/sql/8.1.0.sql Outdated
/* PHP:ps_810_add_product_attribute_lang_data(); */;

/* Update feature flags */
/* PHP:ps_810_update_product_page_feature_flags(); */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* PHP:ps_810_update_product_page_feature_flags(); */
/* PHP:ps_810_update_product_page_feature_flags(); */;

@kpodemski
Copy link
Contributor

ping @jolelievre

@jolelievre jolelievre dismissed stale reviews from 0x346e3730 and mflasquin via 9dcad00 March 29, 2023 11:26
@djoelleuch djoelleuch self-assigned this Apr 17, 2023
djoelleuch
djoelleuch approved these changes Apr 18, 2023
View reviewed changes
Copy link

@djoelleuch djoelleuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jolelievre

I have checked your PR.

The upgrade from PS8.0.1 to PS8.1.0 when multi shop enabled: OK ✔️
The upgrade from PS8.0.1 to PS8.1.0 when single shop enabled : OK ✔️
The upgrade from PS8.0.1 to PS8.1.0 when multi shop and single shop disabled : OK ✔️
The upgrade from PS1788 to PS8.1.0 (From create release .zip) when multi shop and single shop disabled : OK ✔️
the rollback from PS8.1.0 to PS8.0.1 : OK ✔️
the rollback from PS8.1.0 to PS1.7.8.8 : OK ✔️

So, it's QA approved !

Thank You 🚀 !

@kpodemski kpodemski merged commit 35de2e1 into PrestaShop:dev Apr 18, 2023
@kpodemski
Copy link
Contributor

thanks @jolelievre @djoelleuch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HanaRebaiQA HanaRebaiQA HanaRebaiQA left review comments

@kpodemski kpodemski kpodemski approved these changes

@djoelleuch djoelleuch djoelleuch approved these changes

@0x346e3730 0x346e3730 0x346e3730 left review comments

@mflasquin mflasquin Awaiting requested review from mflasquin

Assignees

@djoelleuch djoelleuch

Labels
QA ✔️
Projects
None yet
Milestone
4.16.0
Development

Successfully merging this pull request may close these issues.

BO - The experimental features of the Product V2 is not correct after an upgrade from 8.0.1 to 8.1.0
7 participants
@jolelievre @HanaRebaiQA @kpodemski @mflasquin @0x346e3730 @djoelleuch @AureRita