Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer.lock #578

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Update composer.lock #578

merged 1 commit into from
Apr 11, 2023

Conversation

ValentinGratz
Copy link
Contributor

@ValentinGratz ValentinGratz commented Apr 8, 2023

twig/twig : 1.44.7

Questions Answers
Description? Upgrade twig/twig to 1.44.7
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket?
Sponsor company
How to test? Everything should work as expected this is just a dependency minor update. Can you please verify if HTML pages of the upgrade software are displayed correctly?

twig/twig : 1.44.7
@HanaRebaiQA HanaRebaiQA self-assigned this Apr 11, 2023
Copy link

@HanaRebaiQA HanaRebaiQA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ValentinGratz

I have checked your PR.

  • Upgrade from 1.7.8.8 to 8.0.3 (Check BO and FO) : OK ✔️
  • Rollback from 8.0.3 to 1.7.8.8 (Check BO and FO) : OK ✔️

Except this issue but I verified and it's not related to this PR :
The FO is broken after the upgrade when the debug mode is enabled (I will create a dedicated issue for it)

  • Upgrade from 8.0.3 to 8.1.0 develop (Check BO and FO) : OK ✔️
  • Rollback from 8.1.0 develop to 8.0.3 (Check BO and FO) : OK ✔️

So, it's QA ✔️

Thank You!

@nicosomb nicosomb added this to the 4.16.0 milestone Apr 11, 2023
@nicosomb nicosomb merged commit c430f7c into PrestaShop:dev Apr 11, 2023
@nicosomb
Copy link
Contributor

Thank you @ValentinGratz !

@ValentinGratz
Copy link
Contributor Author

Hello,

I simply applied dependabot's security from github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants