Fix some files not being deleted

[Hlavtox]

Questions	Answers
Description?	Solves a problem of some files not being deleted during upgrade. The common culprit was that these files had /admin in their paths.
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#34385 (partially, don't close)
Sponsor company
How to test?	Upgrade from 1.7.6.9 to 8.1.2 and check that these files from the issue are gone.

How I fixed it

• During my findings like in Fix missing files from folders containing install #651, I got to the step where it builds a list of files to get removed. It builds this list by comparing current version XML to a XML of the target version.
• Files that are on that list, are scheduled for deletion.
• However, I found out that because these files had universal /admin path in them, it was replacing it by our own admin folder. $list_files_diff[$k] = str_replace('/' . 'admin', '/' . $admin_dir, $path);
• However, it was replacing it not only in the beginning, but also in the middle of the paths, resulting in paths of some files to be changed to nonsense.

Before

After

[AureRita]

Hi @Hlavtox

Thank you for your PR, I tested it and it seems to works as you can see :

Untitled_.Nov.23.2023.5_44.PM.webm

But currently we can see that we can't go on the BO, we can go in FO.

When we want to go again in BO to enable debug mode or anything else, we've this error :

Thank you

[Hlavtox]

@AureRita As discussed privately, caused by not filling a session table, fixed here - #655

A workaround is to clear cookies. :-) This will create a new session and the user will be able to log in. This PR is not the problem.