Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill sessions with data after adding the column #655

Merged
merged 1 commit into from Nov 28, 2023

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Nov 23, 2023

Questions Answers
Description? The script doesn't fill new session columns with data, resulting in an error sometimes. This fills it.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes ##652 (comment)
Sponsor company
How to test? Upgrade from 1.7.6.9 to 8.1.2, directly after upgrade, open phpmyadmin and check that there won't be an empty date_add and date_upd in ps_employee_session.

@Hlavtox Hlavtox added this to the 4.16.5 milestone Nov 24, 2023
@Hlavtox Hlavtox mentioned this pull request Nov 27, 2023
@AureRita AureRita self-assigned this Nov 28, 2023
@AureRita
Copy link

Hi @Hlavtox

Thank you for your PR, I tested it and it seems to works as you can see :

Untitled_.Nov.28.2023.10_52.AM.webm

As you can see at the end, we have two session of the id employee 1, it's one from the previous version and one from the last version, don't know if this issue have to block this PR. If not, It'll be QA ✔️

Thank you

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Nov 28, 2023

@AureRita That's normal, you can be logged in from multiple browsers/IPs/whatever. Outdated sessions can be cleaned using the button in BO. :-) Thanks!

@Hlavtox Hlavtox merged commit 0938450 into PrestaShop:dev Nov 28, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants