Set authorization_server feature flag true by default #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
M0rgan01
commented
Feb 28, 2024
•
M0rgan01
commented
| Questions | Answers |
|---|---|
| Description? | Set authorization_server feature true by default |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes PrestaShop/PrestaShop#34852 |
| Sponsor company | - |
| How to test? | after an upgrade to v9, ensure the authorization_server feature flag is true by default |
tleon
approved these changes
Feb 29, 2024
boherm
approved these changes
Feb 29, 2024
AureRita
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Hi @M0rgan01
Thank you for your PR, I tested it and it seems to works as you can see :
recording.173.webm
Tested on :
8.0.5 -> 9.0.0
8.0.5 -> 8.1.5 -> 9.0.0
8.1.5 -> 9.0.0
Because the PR seems to works as expected, It's QA ✔️
Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.