Update required PHP version to 7.1 #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
M0rgan01
commented
May 23, 2024
•
M0rgan01
commented
| Questions | Answers |
|---|---|
| Description? | Switching to php 7.1. Added typing where easily possible. Addition of an alert on installation and on display of the configuration page if the PHP version is not >= 7.1 |
| Type? | improvement |
| BC breaks? | yes |
| Deprecations? | no |
| Fixed ticket? | Fixes PrestaShop/PrestaShop#27087 |
| Sponsor company | - |
| How to test? | Check an installation with a PHP version lower than 7.1 to see the alert. View the configuration page with a PHP version lower than 7.1 to see the alert. The upgrade should work the same way with a PHP version >= 7.1 |
autoupgrade.php
Outdated
Comment on lines
33
to
36
| $autoloadPath = __DIR__ . '/../../vendor/autoload.php'; | ||
| if (file_exists($autoloadPath)) { | ||
| require_once $autoloadPath; | ||
| } |
There was a problem hiding this comment.
I recommend moving this to a place where you have checked the current PHP version is compatible. For instance in the __construct after a call to VersionCheck::_isActualPHPVersionCompatible().
M0rgan01
force-pushed
the
bump_php_7.1
branch
2 times, most recently
from
3baf6d7
to
d4721af
Compare
M0rgan01
force-pushed
the
bump_php_7.1
branch
17 times, most recently
from
5065237
to
ac2fa4f
Compare
AureRita
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Hi @M0rgan01
Thank you for your PR, I tested it and it seems to works as you can see :
recording.231.webm
Tested with php 5.6, 7.0 and 7.1
Tested from :
1.7.1.0 to 1.7.8.11
1.7.8.11 to 8.1.6
8.0.5 to 8.1.6
8.1.5 to 8.1.6
8.1.6 to 9.0.0
8.0.5 to 9.0.0
8.1.5 to 9.0.0
Because the PR seems to works as expected, It's QA ✔️
Thank you
ga-devfront
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.