Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad display of Customer data privacy message when the text contains a link #57

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Bad display of Customer data privacy message when the text contains a link #57

merged 1 commit into from
Oct 10, 2022

Conversation

AlexTechDev
Copy link
Contributor

Questions Answers
Description? When we add a link in the text of data privacy the text stands out from the div. If we add to the class .custom-checkbox the property word-break: break-word; we prevent this.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#27155
How to test? Go to BO> Modules> Module manager > Configure the module Customer data privacy block
add a link in the message and save
Go to Front office and open the account creation page

@matks matks added the Waiting for QA Status: Waiting for QA feedback label Sep 28, 2022
@florine2623 florine2623 self-assigned this Oct 6, 2022
florine2623
florine2623 approved these changes Oct 7, 2022
View reviewed changes
Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @AlexTechDev ,

Before:
Screenshot 2022-10-07 at 10 09 35

After:
Screenshot 2022-10-07 at 10 08 45

It is QA ✅

Thanks!

@florine2623 florine2623 added QA ✔️ Status: QA-Approved and removed Waiting for QA Status: Waiting for QA feedback labels Oct 7, 2022
@Progi1984 Progi1984 added this to the 2.0.2 milestone Oct 7, 2022
@NeOMakinG NeOMakinG merged commit a9f8a6d into PrestaShop:develop Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodemski kpodemski kpodemski approved these changes

@matks matks matks approved these changes

@florine2623 florine2623 florine2623 approved these changes

Assignees

@florine2623 florine2623

Labels
QA ✔️ Status: QA-Approved
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.

FO - ps_dataprivacy- Bad display of Customer data privacy message when the text contains a link
6 participants
@AlexTechDev @kpodemski @matks @florine2623 @Progi1984 @NeOMakinG