-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hook registration for upgraded versions #66
Conversation
kpodemski
commented
Mar 8, 2023
Questions | Answers |
---|---|
Description? | This will force the module to hook into displayContactContent, so it works in the new version of Classic |
Type? | bug fix |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | Fixes PrestaShop/PrestaShop#31640 |
How to test? | After the upgrade, update to this module version (it may require creating a .zip manually for the test) and see if the contactform is displayed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @kpodemski
Thanks for your PR 🚀
- 1.7.8.8 upgraded to 8.0.1: the contact form is well displayed after the upgrade (with and without PR 😅 )
- 8.0.0 upgraded to 8.0.1: the contact form is well displayed after the upgrade but the Store information is not displayed ❌ see the attached screenshots below:
Before Upgrade and after the Rollback:
Thanks!
Hello @hibatallahAouadni Store information is a different module, it's ok. There's an update for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @kpodemski
BTW, to summarize we can reproduce the issue only in these cases:
- contactform v4.3.0: 1788->801
- contactform v4.3.0: 800->801
- contactform v4.4.0: 800->801
And with your PR:
- 1788->801 ✅
- 800->801 ✅
LGTM, QA ✅
Thanks!
thanks @hibatallahAouadni |