Fix hook registration for upgraded versions #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kpodemski
commented
Mar 8, 2023
kpodemski
commented
| Questions | Answers |
|---|---|
| Description? | This will force the module to hook into displayContactContent, so it works in the new version of Classic |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes PrestaShop/PrestaShop#31640 |
| How to test? | After the upgrade, update to this module version (it may require creating a .zip manually for the test) and see if the contactform is displayed |
SharakPL
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
Hello @kpodemski
Thanks for your PR 🚀
- 1.7.8.8 upgraded to 8.0.1: the contact form is well displayed after the upgrade (with and without PR 😅 )
- 8.0.0 upgraded to 8.0.1: the contact form is well displayed after the upgrade but the Store information is not displayed ❌ see the attached screenshots below:
After Upgrade:
Before Upgrade and after the Rollback:
Thanks!
|
Hello @hibatallahAouadni Store information is a different module, it's ok. There's an update for |
hibatallahAouadni
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
Hello @kpodemski
BTW, to summarize we can reproduce the issue only in these cases:
- contactform v4.3.0: 1788->801
- contactform v4.3.0: 800->801
- contactform v4.4.0: 800->801
And with your PR:
- 1788->801 ✅
- 800->801 ✅
LGTM, QA ✅
Thanks!
|
thanks @hibatallahAouadni |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.