This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
PrestaShop 1.7 compatibility #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| $cart = $this->context->cart; | ||
| if (!$cart->id_carrier) { | ||
| die(json_encode(['success' => false])); |
There was a problem hiding this comment.
Can you use ajaxRender instead die?
There was a problem hiding this comment.
It's not only because of hook and even if you never use something that doesn't mean nobody is using it :).
die should never be used in MVC / MOVE context. You can break an other module, some sql requests, or anything (maybe the Symfony Framework) because you instantly stop the process without be sure a rollback isn't needed.
There was a problem hiding this comment.
@PierreRambaud, if we replace die with ajaxRender, we break the compatibility with old versions of PrestaShop. I'd keep them here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.