Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install scripts #180

Merged
merged 7 commits into from Sep 23, 2019

Conversation

@djodjo3
Copy link
Contributor

commented Sep 20, 2019

  • Additional scripts can now be run:
    => At pre-install (after files copy)
    => At post-install (after PS setup)
    => At init (just before webserver launch)
    At each step, will check if scripts are available and will run them
  • Adding some more logs during script run
  • Script will crash if any step fails
  • Replace mysqladmin drop DB with mysql drop if exists DB
@Quetzacoalt91

This comment has been minimized.

Copy link
Member

commented Sep 23, 2019

Looks like there is a small indentation issue in the script. Can you please double check?

When that's done, you may run the file base/generate_tags.sh to spread the changes in each subfolder.

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

Looks like there is a small indentation issue in the script. Can you please double check?

When that's done, you may run the file base/generate_tags.sh to spread the changes in each subfolder.

Yes, the script contains tabs and spaces, even before his change, this is why I approved 😅

djodjo3 and others added 4 commits Sep 23, 2019
Co-Authored-By: Thomas N <Quetzacoalt91@users.noreply.github.com>
…llScripts

Conflicts:
	base/config_files/docker_run.sh
Claude-Arnaud Perrot
@djodjo3

This comment has been minimized.

Copy link
Contributor Author

commented Sep 23, 2019

  • Fixed the indentation issue (tentatively, but let me know)
  • Fixed a typo (DN_NAME instead of DB_NAME...)
  • Ran the base/generate_tags.sh script, does not seem to have changed much - I suppose it's to be expected as I only updated the docker_run.sh file.
@Quetzacoalt91 Quetzacoalt91 merged commit 217e9e3 into PrestaShop:master Sep 23, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Copy link
Member

commented Sep 23, 2019

Thank you @djodjo3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.