Add missing versions, use proper php version and add erase / install database parameters #226
Conversation
| fi | ||
| if ((10#${ver1[i]} > 10#${ver2[i]})) | ||
| then | ||
| return 1 |
There was a problem hiding this comment.
The return 1|2 is a bit weird no? Usually for comparison functions you return 1, -1 or 0 when equal
There was a problem hiding this comment.
Only in PHP, it depends on the language :p
There was a problem hiding this comment.
That's clearly not only in PHP but doesn't matter ^^ You're right that conventions differ from language to language
There was a problem hiding this comment.
And this part of code came from stackoverflow. I plan to refactor this script in a proper language like python in order to make it more customizable and manage correctly PHP and PS versions.
| @@ -123,3 +123,6 @@ | |||
| 1.7.6.4 | |||
| 1.7.6.5 | |||
| 1.7.6.7 | |||
| 1.7.6.6 | |||
| 1.7.6.7 | |||
| 1.7.7.0-beta.2 | |||
There was a problem hiding this comment.
How come we add the beta build this time? Seems like we never did it for previous versions 🤔
There was a problem hiding this comment.
It creates the Dockerfile for the beta version, but we must push it manually for the moment.
I plan to refactor this repository in order to manage property PHP / PrestaShop version.
There was a problem hiding this comment.
Mmm, but we didn't push any other beta, so why this one?
Unless we clean them when the official release is ready?
There was a problem hiding this comment.
It's a new demand from the community, they created an issue weeks ago. We will do it for all our versions, beta, alpha, RC, etc.
There was a problem hiding this comment.
So it's in addition with the already existing beta build? This one is built on the branch last nighly build though so I guess the community needs a Docker that matches the beta tag?
There was a problem hiding this comment.
PrestaShop/PrestaShop#20563 They are also able to use the nightly build, but for testing usage, it's also better to have access to the same beta build we pushed on the dot com.
There was a problem hiding this comment.
Ok nice improvement indeed! I'll just add the issue in the description to understand the new need
Also we might need to update the release doc, because now we will have to update the docker images for each pre-release build
PS_INSTALL_DBparameterAlso now build image for pre-release builds as was asked in this core issue PrestaShop/PrestaShop#20563