Improve HelperOptions doc #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jf-viguier
commented
Oct 13, 2021
jf-viguier
commented
| Questions | Answers |
|---|---|
| Branch? | 1.7.x |
| Description? | Improve HelperOptions doc: more examples and new array notation |
| Fixed ticket? | old pr here #1075 |
Progi1984
reviewed
Oct 13, 2021
|
@Progi1984 is it ok now ? |
Progi1984
approved these changes
Oct 22, 2021
atomiix
reviewed
Oct 26, 2021
ghost
approved these changes
Oct 28, 2021
atomiix
approved these changes
Nov 3, 2021
matthieu-rolland
approved these changes
Nov 4, 2021
|
thank you @jf-viguier ! |
|
This one needs to be backported to 8.x |
|
@eternoendless done here #1212 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.