Update 1.7.x nginx template ; part 2 #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify back office `rewrite` rule. `rewrite` takes a regex to match against the URI, but since we don’t care about what the URI is we just use a `^` which means “beginning of string” and thus matches everything.
Simplify installation sandbox `rewrite` rule by removing the second capture group, since it's not being used.
Improve product images `rewrite` rules.
Consider the following example for easier reading:
```regexp
^/([0-9])([0-9])(-[_a-zA-Z0-9-]*)?(-[0-9]+)?/.+.jpg$ /img/p/$1/$2/$1$2$3$4.jpg last;
^/(\d)(\d)(-[\w-]+)?/.+\.jpg$ /img/p/$1/$2/$1$2$3.jpg last;
```
* Replace `[0-9]` with `\d`.
* Replace `[_a-zA-Z0-9-]` with `[\w-]`.
* Remove the last capture group `(-[0-9]+)?` as it is already matched
in the previous capture group.
* Properly escape the dot character (`\.`) used in the file
extension: `\.jpg`.
Improve category images `rewrite` rules. * Unlike product images, we only need to capture what is in the second level of the URI, so there is no need to have multiple regular expressions to achieve this task. Taking into account previous rules, the list of allowed characters is set to include any alphanumeric characters `\w`, the dot `.`, and the hyphen `-`, simplifying the whole capture group to: `([\w.-]+)` * Properly escape the dot character (`\.`) used in the file extension: `\.jpg`.
PierreRambaud
approved these changes
Oct 15, 2021
|
Thank you @juangiordana |
matks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rewriterules.rewriterules.