Fix usage of underscores in new translation system page #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpontet
commented
Jan 26, 2022
jonpontet
commented
| Questions | Answers |
|---|---|
| Branch? | 1.7.x |
| Description? | You have incorrectly used underscores instead of hyphens |
| Fixed ticket? | n/a |
You have incorrectly used underscores instead of hyphens
matks
changed the title
matks
reviewed
Feb 2, 2022
There was a problem hiding this comment.
Hi @jonpontet PR seems OK but I asked confirmation about it to someone else to make sure this is indeed the right change ;)
jonpontet
changed the title
atomiix
approved these changes
Feb 3, 2022
|
Thank you @jonpontet I see the approval of @atomiix 👍 |
kpodemski
added a commit
that referenced
this pull request
Sep 20, 2022
Fix usage of underscores in new translation system page (Backported #1279)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.